Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vhd-lib): speed up merge #6100

Merged
merged 3 commits into from
Jan 24, 2022
Merged

feat(vhd-lib): speed up merge #6100

merged 3 commits into from
Jan 24, 2022

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Jan 19, 2022

Make coalesce call in parallel for vhd directory, write mergeState one every 110 seconds

speed : 1-4 block / second => 40 blocks per second

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

packages/vhd-lib/merge.js Outdated Show resolved Hide resolved
packages/vhd-lib/merge.js Outdated Show resolved Hide resolved
julien-f pushed a commit that referenced this pull request Jan 20, 2022
packages/vhd-lib/merge.js Outdated Show resolved Hide resolved
@fbeauchamp fbeauchamp force-pushed the feat_merge_speedup branch 3 times, most recently from 2bbf1dc to 4bdc23a Compare January 20, 2022 16:05
@fbeauchamp fbeauchamp requested a review from julien-f January 20, 2022 16:06
packages/vhd-lib/merge.js Outdated Show resolved Hide resolved
packages/vhd-lib/merge.js Outdated Show resolved Hide resolved
@julien-f julien-f merged commit 97d94b7 into master Jan 24, 2022
@julien-f julien-f deleted the feat_merge_speedup branch January 24, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants