Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/install patches): improve confirm message #6159

Merged
merged 4 commits into from
Mar 29, 2022

Conversation

Rajaa-BARHTAOUI
Copy link
Contributor

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI commented Mar 29, 2022

Screenshots

Capture d’écran de 2022-03-29 11-23-06

Capture d’écran de 2022-03-29 11-23-21

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI force-pushed the confirmMessageInstallPatches branch from 30f3eeb to 65af29a Compare March 29, 2022 05:53
@MathieuRA MathieuRA requested a review from pdonias March 29, 2022 07:43
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
@Rajaa-BARHTAOUI Rajaa-BARHTAOUI requested a review from pdonias March 29, 2022 09:10
@pdonias pdonias changed the title feat(xo-web/installPatches): improve confirm message feat(xo-web/install patches): improve confirm message Mar 29, 2022
@pdonias pdonias merged commit 5468595 into master Mar 29, 2022
@pdonias pdonias deleted the confirmMessageInstallPatches branch March 29, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants