Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/migrate/vm): allow to select private network for VIFs network #6200

Merged
merged 5 commits into from
Apr 26, 2022

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Apr 22, 2022

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA MathieuRA requested a review from fbeauchamp April 22, 2022 07:49
@fbeauchamp fbeauchamp requested a review from pdonias April 22, 2022 08:08
@MathieuRA MathieuRA requested a review from pdonias April 25, 2022 15:21
@MathieuRA MathieuRA requested a review from pdonias April 26, 2022 13:19
@pdonias pdonias changed the title feat(wo-web/migrate/vm): allow to select private network for VIFs network feat(xo-web/migrate/vm): allow to select private network for VIFs network Apr 26, 2022
@pdonias pdonias merged commit 3c1239c into master Apr 26, 2022
@pdonias pdonias deleted the migratePrivateNetw branch April 26, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants