Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server/proxy-console): don't close client socket before legacy fallback #6203

Merged
merged 3 commits into from
Apr 29, 2022

Conversation

fbeauchamp
Copy link
Collaborator

a race condition was closing the socket when fallin back to legacy code. Add the error/close listenner only when the sock

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@julien-f julien-f changed the title fix(console): better handling of console on legacy xenserver fix(xo-server/proxy-console): don't close client socket before legacy fallback Apr 25, 2022
@fbeauchamp fbeauchamp force-pushed the fix_console_bis branch 2 times, most recently from 40f5fdf to 21d8e5a Compare April 25, 2022 12:32
@fbeauchamp fbeauchamp requested a review from julien-f April 29, 2022 13:18
fbeauchamp and others added 3 commits April 29, 2022 15:23
a race condition was closing the socket when fallin back to legacy code. Add the error/close listenner only when the sock
@julien-f julien-f merged commit e740719 into master Apr 29, 2022
@julien-f julien-f deleted the fix_console_bis branch April 29, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants