Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server/checkBackupNg): wait for VM to be running before watching guest metrics #6214

Merged
merged 5 commits into from
May 3, 2022

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Apr 29, 2022

Introduced by 7d6e832

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp requested a review from julien-f April 29, 2022 17:08
@fbeauchamp fbeauchamp changed the title fix(restore health check): use more precise polling to detect xen tools Wip: fix(restore health check): use more precise polling to detect xen tools Apr 29, 2022
@fbeauchamp fbeauchamp force-pushed the fix_restore_health_check branch from eb8a82d to ef35122 Compare May 3, 2022 09:49
@fbeauchamp fbeauchamp requested a review from julien-f May 3, 2022 09:51
@fbeauchamp fbeauchamp force-pushed the fix_restore_health_check branch from ef35122 to 8618b5b Compare May 3, 2022 09:52
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@fbeauchamp fbeauchamp requested a review from julien-f May 3, 2022 12:48
@fbeauchamp fbeauchamp changed the title Wip: fix(restore health check): use more precise polling to detect xen tools fix(restore health check): use more precise polling to detect xen tools May 3, 2022
@julien-f julien-f changed the title fix(restore health check): use more precise polling to detect xen tools fix(xo-server/checkBackupNg): wait for VM to be running before watching guest metrics May 3, 2022
@julien-f julien-f merged commit 150c552 into master May 3, 2022
@julien-f julien-f deleted the fix_restore_health_check branch May 3, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants