Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(S3#_list): handle empty directory #6218

Merged
merged 2 commits into from
May 17, 2022
Merged

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented May 4, 2022

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp force-pushed the fix_s3_emptuy_directory branch from 323c6a9 to 9ac896c Compare May 4, 2022 15:29
@fbeauchamp fbeauchamp requested a review from julien-f May 17, 2022 06:57
@fbeauchamp fbeauchamp marked this pull request as ready for review May 17, 2022 06:57
@julien-f julien-f changed the title fix(S3): handle empty directory fix(S3#_list): handle empty directory May 17, 2022
@julien-f julien-f merged commit 01810f3 into master May 17, 2022
@julien-f julien-f deleted the fix_s3_emptuy_directory branch May 17, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants