Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot vusbs #6239

Merged
merged 2 commits into from
May 24, 2022
Merged

Snapshot vusbs #6239

merged 2 commits into from
May 24, 2022

Conversation

julien-f
Copy link
Member

@julien-f julien-f commented May 17, 2022

To merge without squashing.

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@julien-f julien-f requested a review from olivierlambert May 19, 2022 07:07
Copy link
Member

@olivierlambert olivierlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functionally, works as intended.

@julien-f julien-f requested a review from fbeauchamp May 23, 2022 07:35
@julien-f julien-f marked this pull request as ready for review May 23, 2022 08:04
@julien-f julien-f requested review from fbeauchamp and removed request for fbeauchamp May 24, 2022 09:37
@julien-f julien-f merged commit b75ca27 into master May 24, 2022
@julien-f julien-f deleted the snapshot-vusbs branch May 24, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants