Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: speedup vmdk generation by relaxing compression, orphan task, ova does not contains ovf error #6267

Merged
merged 3 commits into from
Jun 9, 2022

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Jun 3, 2022

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp changed the title fix: speedup vmdk generation by relaxing compression fix: speedup vmdk generation by relaxing compression - fix orphan task Jun 8, 2022
@fbeauchamp fbeauchamp marked this pull request as ready for review June 8, 2022 14:28
@fbeauchamp fbeauchamp changed the title fix: speedup vmdk generation by relaxing compression - fix orphan task fix: speedup vmdk generation by relaxing compression, orphan task, ova does not contains ovf error Jun 8, 2022
@fbeauchamp fbeauchamp requested a review from julien-f June 8, 2022 15:22
@julien-f julien-f force-pushed the fix_ova_speed branch 3 times, most recently from 370c309 to 710e621 Compare June 9, 2022 15:13
@julien-f julien-f merged commit c11e03a into master Jun 9, 2022
@julien-f julien-f deleted the fix_ova_speed branch June 9, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants