Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web): display maintenance mode badge next to the SR name #6313

Merged
merged 4 commits into from
Jul 1, 2022

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Jun 30, 2022

Screenshot

Capture d’écran de 2022-06-30 15-48-59

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI requested a review from pdonias June 30, 2022 14:18
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Co-authored-by: Pierre Donias <[email protected]>
@MathieuRA MathieuRA requested a review from pdonias July 1, 2022 14:19
@pdonias pdonias changed the title feat(xo-web): display maintenance mode badge next to the sr name feat(xo-web): display maintenance mode badge next to the SR name Jul 1, 2022
@pdonias pdonias merged commit c7192ed into master Jul 1, 2022
@pdonias pdonias deleted the ui_2_sr_maintenance_mode branch July 1, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants