Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/remote): show encryption in remote UI #6465

Merged
merged 4 commits into from
Oct 24, 2022
Merged

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Oct 17, 2022

  • if remote is disabled we don't know the used algorithm : only show the lock if there is an encryption key
  • if remote is enabled :
    • if algorithm is undefined or none : show nothing, remote is not encrypted
    • if algorithm is defined to DEFAULT_ENCRYPTION_ALGORITHM : show the lock with the name of the algorithm as a tooltip
    • else show the lock and a warning advising to create a new remote with an up to date algorithm

Screenshot

image

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp requested a review from MathieuRA October 19, 2022 08:02
@fbeauchamp fbeauchamp marked this pull request as ready for review October 19, 2022 08:02
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/settings/remotes/index.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias October 20, 2022 12:42
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/settings/remotes/index.js Outdated Show resolved Hide resolved
@fbeauchamp fbeauchamp requested a review from MathieuRA October 24, 2022 07:37
@MathieuRA MathieuRA requested a review from pdonias October 24, 2022 08:49
@pdonias pdonias changed the title feat(xo-web): show encryption in remote UX feat(xo-web/remote): show encryption in remote UI Oct 24, 2022
@pdonias pdonias merged commit b60f5d5 into master Oct 24, 2022
@pdonias pdonias deleted the feat_ux_encryption branch October 24, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants