Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/VM/advanced): add button for warm migration #6533

Merged
merged 10 commits into from
Nov 29, 2022

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Nov 16, 2022

DOT NOT MERGE. See #6549

Screenshot

Capture d’écran de 2022-11-16 17-01-08
Capture d’écran de 2022-11-25 14-26-09

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA MathieuRA self-assigned this Nov 16, 2022
@MathieuRA MathieuRA changed the title feat(xo-web/VM/advanced): add button for lukewarm migration feat(xo-web/VM/advanced): add button for warm migration Nov 16, 2022
packages/xo-web/src/xo-app/vm/tab-advanced.js Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Show resolved Hide resolved
CHANGELOG.unreleased.md Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias November 28, 2022 09:36
@MathieuRA MathieuRA force-pushed the mathieu/lukewarmMigration branch from bc910ce to e22ab7f Compare November 29, 2022 09:05
@fbeauchamp fbeauchamp force-pushed the mathieu/lukewarmMigration branch from e22ab7f to 26e2145 Compare November 29, 2022 14:11
@fbeauchamp
Copy link
Collaborator

fbeauchamp commented Nov 29, 2022

tested locally and rebased on master

@pdonias pdonias merged commit f3a09f2 into master Nov 29, 2022
@pdonias pdonias deleted the mathieu/lukewarmMigration branch November 29, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants