-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(xo-web/recipes): static network config for k8s recipe #6598
Conversation
Co-authored-by: Pierre Donias <[email protected]>
Co-authored-by: rajaa-b <[email protected]>
Co-authored-by: rajaa-b <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't forget to add the screenshot to the PR description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the remaining comments?
Co-authored-by: rajaa-b <[email protected]>
Co-authored-by: rajaa-b <[email protected]>
I fixed the issue. If you want to test the feature:
|
@ggunullu Don't you want to add a Changelog entry for this? |
I thought I had added a changelog entry, I can see it right now in vscode 🤔 EDIT: There is already a |
Check list
Fixes #007
orSee xoa-support#42
)CHANGELOG.unreleased.md
:${name} v${new version}
)cron/parse.spec.js
)xo-server
API changes, the corresponding test has been added to/updated onxo-server-test
Process
WiP:
(Work in Progress) if not ready to be mergedFrom the Four Agreements: