Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-vmdk-to-vhd): better computation of overprovisioning of very sparse disks #6639

Merged
merged 5 commits into from
Jan 30, 2023

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Jan 25, 2023

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp marked this pull request as ready for review January 27, 2023 10:04
@fbeauchamp fbeauchamp requested a review from julien-f January 27, 2023 10:04
@fbeauchamp fbeauchamp force-pushed the fix_ova_overprovionning branch from 4cfb6d8 to bc7116f Compare January 30, 2023 13:12
@julien-f julien-f changed the title Fix(xo-vmdk-to-vhd): better computation of overprovisionning of very sparse disks fix(xo-vmdk-to-vhd): better computation of overprovisioning of very sparse disks Jan 30, 2023
@julien-f julien-f merged commit 1039728 into master Jan 30, 2023
@julien-f julien-f deleted the fix_ova_overprovionning branch January 30, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants