Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/host/network): remove extra "mode" column #6640

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Jan 25, 2023

Introduced by 7ede6bd

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@pdonias pdonias requested a review from fbeauchamp January 25, 2023 15:44
@pdonias pdonias force-pushed the pierre-remove-extra-mode-column branch from 7ee76d6 to d42cd73 Compare January 25, 2023 15:46
@pdonias pdonias merged commit 53f4f26 into master Jan 25, 2023
@pdonias pdonias deleted the pierre-remove-extra-mode-column branch January 25, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants