-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(xo-web/home): icon grouping #6655
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuRA
force-pushed
the
remove-tooltips-icon
branch
from
February 3, 2023 15:35
afee0bc
to
0d34ac8
Compare
MathieuRA
changed the title
Wip: feat(xo-web/home): icon grouping
feat(xo-web/home): icon grouping
Feb 6, 2023
MathieuRA
force-pushed
the
remove-tooltips-icon
branch
from
February 6, 2023 14:22
f3bab69
to
54c3d50
Compare
MathieuRA
force-pushed
the
remove-tooltips-icon
branch
2 times, most recently
from
February 6, 2023 14:34
a75f6f1
to
eae1a60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't forget to include the entry in the changelog.
pdonias
requested changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, don't forget to update the screenshots in the PR description.
MathieuRA
force-pushed
the
remove-tooltips-icon
branch
from
March 6, 2023 14:50
f0da70c
to
52c0b68
Compare
Co-authored-by: rajaa-b <[email protected]>
…ra into remove-tooltips-icon
Rajaa-BARHTAOUI
requested review from
pdonias
and removed request for
Rajaa-BARHTAOUI
March 13, 2023 13:54
pdonias
approved these changes
Mar 14, 2023
Rajaa-BARHTAOUI
approved these changes
Mar 14, 2023
@pdonias Can you merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
Before
After
Check list
Fixes #007
orSee xoa-support#42
)CHANGELOG.unreleased.md
:${name} v${new version}
)cron/parse.spec.js
)xo-server
API changes, the corresponding test has been added to/updated onxo-server-test
Process
WiP:
(Work in Progress) if not ready to be mergedFrom the Four Agreements: