feat(xo-web/import/esxi): import VM from ESXi

[Rajaa-BARHTAOUI]

• Backend PR: Feat(xo-server): implement Api for esxi migration UX #6662
• List expected from the function to connect to ESXi:

[
  {
    id: '1',
    nameLabel: 'test_linux',
    memory: 2147483648,
    nCpus: 1,
    guestToolsInstalled: false,
    firmware: 'bios',
    powerState: 'poweredOff',
    storage: {
      used: 216761,
      free: 2318061568,
    },
  },
  {
    id: '2',
    nameLabel: 'test_small',
    memory: 2147483648,
    nCpus: 1,
    guestToolsInstalled: false,
    firmware: 'bios',
    powerState: 'poweredOff',
    storage: {
      used: 10696,
      free: 2586497520,
    },
  },
]

• Params provided to vm.importFromEsxi

 {
    host: '192.168.2.20',
    network: '6b309876-9b61-6feb',
    password: 'password',
    sr: '86a9757d-9c05-9fe0-e79a',
    sslVerify: false,
    user: 'user',
    vm: '1',
    },
  }
  

Screenshots

Check list

Check if done, if not relevant leave unchecked.

• PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
• if UI changes, a screenshot has been added to the PR
• documentation updated
• CHANGELOG.unreleased.md:
  • enhancement/bug fix entry added
  • list of packages to release updated (${name} v${new version})
• I have tested added/updated features (and impacted code)
  • unit tests (e.g. cron/parse.spec.js)
  • if xo-server API changes, the corresponding test has been added to/updated on xo-server-test
  • at least manual testing

Process

1. create a PR as soon as possible
2. mark it as WiP: (Work in Progress) if not ready to be merged
3. when you want a review, add a reviewer (and only one)
4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

1. Be impeccable with your word.
2. Don't take anything personally.
3. Don't make assumptions.
4. Always do your best.

[fbeauchamp]

Tests done :

• can't import from ova ( when dropping an ova it does not show the network/ disk form )
• can't import from xva import button stay disabled when dropping a xva
• can't select ova format when importing from url
• can't unselect ssl certificate page when importing to esxi ( thus, I am not able to test esxi import since our server need to uncheck this)

[olivierlambert]

I would prefer a dedicated page, as explained in the original issue (Import/From VMware), allowing multi VMs import, which is a special process we don't have in the "Import/VM" view.

[Rajaa-BARHTAOUI]

Tests done :

* can't import from ova ( when dropping an ova it does not show the network/ disk form )

* can't import from xva import button stay disabled when dropping a xva

* can't select ova format when importing from url

* can't unselect ssl certificate page when importing to esxi ( thus, I am not able to test esxi import since our server need to uncheck this)

• Fixed
• Fixed
• It's already the case: URL import is only for XVA files
• Fixed

[Rajaa-BARHTAOUI]

I would prefer a dedicated page, as explained in the original issue (Import/From VMware), allowing multi VMs import, which is a special process we don't have in the "Import/VM" view.

• As a first step, we decided to allow the import of one VM.

[fbeauchamp]

test done : rebase from master ( since there is fix on import, merge from branch #6662 )

• import ova /xva : import ok, but got error :
  
• import from esxi :
  • connect ok
  • list VMs show a list without any label
  • the VM to import don't have any detail except memory
  • clicking on the import give an invalid parameter message
    2023-02-17T10_59_59.772Z - XO.log

[fbeauchamp]

Test done

test Protocol

• pulled this branch
• rebase master onto it, since there is fixes on ova /vmdk handling
• merged the backend branch into it to get new response format from esxi.connect api method

import XVA

• the import button does not stay disabled during the import
• a succes alert should be shown at the end
• user should be redirected to imported VM when done
• Not tested : the button should turn orange on import error
• import seems to have worked

import Ova

• the import button does not stay disabled with text importing during import
• user should be redirected to imported VM when done
• a succes alert should be shown at the end
• Not tested : the button should turn orange on import error
• import seems to have worked

import from url

• not tested

import from esxi

• connect ok
• connect with improper parameters : show error ok
• vm listing ok
• network should have a default value ( as during the ova import )
• additionnal fields : not handled by backend or now
• the import button does not stay disabled with text importing during import
• a succes alert should be shown at the end
• user should be redirected to imported VM when done (when importing 1 VM )

[fbeauchamp]

Test

Protocol

branch are up to date and includes necessary backend method

ova /xva import

• got a translation problem :
  
• button : OK
• import : ok
• success toast ok
• redirect after importing : Not ok

from esxi

• bad connect data : error message is ok
• connect with the right data : ok
• Vm listing : ok
• importing fail with
  
  Reselecting the network and it works
• importing : ok
• button : ok

[fbeauchamp]

Test

protocol

only need to pull the branch

xva / ova import : ok

import esxi : still running , but no error on start

[fbeauchamp]

functionnal tests are ok for me

[pdonias]

LGTM but I don't know how to test it. @Rajaa-BARHTAOUI or @fbeauchamp, can you do a last end-to-end test after the latest changes?

[Rajaa-BARHTAOUI]

LGTM but I don't know how to test it. @Rajaa-BARHTAOUI or @fbeauchamp, can you do a last end-to-end test after the latest changes?

It has been tested after the latest changes, and everything is still running.

[pdonias]

Ok, then this PR is ready to merge after #6662.