-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(xo-server-usage-report): change dataset size #6723
Conversation
What does this PR fix? I don't understand the changes from the screenshots. |
It fixes this issue : https://help.vates.fr/#ticket/zoom/12215 Basically, the plugin is sending a usage report corresponding to the average usage on one year even though the user chose the daily option (therefore the report should show the last day usage). On the second screenshot, you can see the CPU usage sent by the report (2.09%) is not matching the last day consumption of the CPU in the stats tab on XO (first screenshot). |
Co-authored-by: Julien Fontanet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflicts with master
.
be05870
to
822033e
Compare
Fixes Zammad#12215
Screenshots
The CPU usage for the VM
xolab.localdomain
:The old report:
The report now:
Description
Basically, the plugin is sending a usage report corresponding to the average usage on one year even though the user chose the daily option (therefore the report should show the last day usage).
On the second screenshot, you can see the CPU usage sent by the report (2.09%) is not matching the last day consumption of the CPU in the stats tab on XO (first screenshot).
The last screenshot, you can see that the new version of the plugin is sending an accurate value for the CPU usage.
Check list
Fixes #007
orSee xoa-support#42
)CHANGELOG.unreleased.md
:${name} v${new version}
)cron/parse.spec.js
)xo-server
API changes, the corresponding test has been added to/updated onxo-server-test
Process
WiP:
(Work in Progress) if not ready to be mergedFrom the Four Agreements: