Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server-usage-report): change dataset size #6723

Merged
merged 8 commits into from
Apr 6, 2023

Conversation

ggunullu
Copy link
Contributor

@ggunullu ggunullu commented Mar 13, 2023

Fixes Zammad#12215

Screenshots

The CPU usage for the VM xolab.localdomain:
stats_day
The old report:
report_before
The report now:
report_after

Description

Basically, the plugin is sending a usage report corresponding to the average usage on one year even though the user chose the daily option (therefore the report should show the last day usage).

On the second screenshot, you can see the CPU usage sent by the report (2.09%) is not matching the last day consumption of the CPU in the stats tab on XO (first screenshot).
The last screenshot, you can see that the new version of the plugin is sending an accurate value for the CPU usage.

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@ggunullu ggunullu requested a review from fbeauchamp March 13, 2023 08:42
@ggunullu ggunullu changed the title Gab stats granularity fix(xo-server-usage-report): change dataset size Mar 13, 2023
packages/xo-server-usage-report/src/index.js Outdated Show resolved Hide resolved
packages/xo-server-usage-report/src/index.js Outdated Show resolved Hide resolved
@ggunullu ggunullu requested a review from fbeauchamp March 30, 2023 15:00
@ggunullu ggunullu requested a review from fbeauchamp March 30, 2023 15:47
@fbeauchamp fbeauchamp requested a review from julien-f April 4, 2023 07:17
@julien-f
Copy link
Member

julien-f commented Apr 4, 2023

What does this PR fix? I don't understand the changes from the screenshots.

@ggunullu
Copy link
Contributor Author

ggunullu commented Apr 4, 2023

What does this PR fix? I don't understand the changes from the screenshots.

It fixes this issue : https://help.vates.fr/#ticket/zoom/12215

Basically, the plugin is sending a usage report corresponding to the average usage on one year even though the user chose the daily option (therefore the report should show the last day usage).

On the second screenshot, you can see the CPU usage sent by the report (2.09%) is not matching the last day consumption of the CPU in the stats tab on XO (first screenshot).
The last screenshot, you can see that the new version of the plugin is sending an accurate value for the CPU usage.

@ggunullu ggunullu requested a review from julien-f April 6, 2023 12:31
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts with master.

@ggunullu ggunullu force-pushed the gab-stats_granularity branch from be05870 to 822033e Compare April 6, 2023 12:40
@ggunullu ggunullu requested a review from julien-f April 6, 2023 12:41
@julien-f julien-f merged commit 0834836 into master Apr 6, 2023
@julien-f julien-f deleted the gab-stats_granularity branch April 6, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants