Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xo-web/home/pool): switch alert support from 'danger' to 'warning' #6849

Merged
merged 5 commits into from
Jun 12, 2023
Merged

fix(xo-web/home/pool): switch alert support from 'danger' to 'warning' #6849

merged 5 commits into from
Jun 12, 2023

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented May 22, 2023 •
edited
Loading

Screenshot

Capture d’écran de 2023-05-22 09-56-17

Description

After a discussion with Olivier, a decision was made to change the alert support as a warning in the pool home view to harmonize with the host home view.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this May 22, 2023
@MathieuRA MathieuRA marked this pull request as ready for review May 22, 2023 08:02
@MathieuRA MathieuRA requested a review from Rajaa-BARHTAOUI May 22, 2023 08:02
@Rajaa-BARHTAOUI Rajaa-BARHTAOUI requested a review from pdonias May 31, 2023 14:55
@MathieuRA MathieuRA requested review from julien-f and removed request for pdonias June 8, 2023 08:13
julien-f
julien-f reviewed Jun 9, 2023
View reviewed changes
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add.

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI requested a review from julien-f June 12, 2023 09:45
@julien-f julien-f merged commit 1fb7e66 into master Jun 12, 2023
@julien-f julien-f deleted the pool/support-level-warning branch June 12, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI Rajaa-BARHTAOUI approved these changes

@julien-f julien-f Awaiting requested review from julien-f

Assignees

@MathieuRA MathieuRA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MathieuRA @julien-f @Rajaa-BARHTAOUI