feat(xo-server-netbox): synchronize VM tags #6957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdonias
force-pushed
the
pierre-netbox-sync-tags
branch
2 times, most recently
from
9f2fc81 to
d8f5594
Compare
julien-f
reviewed
Aug 7, 2023
| @@ -306,7 +306,7 @@ class Netbox { | |||
|
|
|||
| log.info('Synchronizing VMs') | |||
|
|
|||
| const createNetboxVm = async (vm, { cluster, platforms }) => { | |||
| const createNetboxVm = async (vm, { cluster, platforms, netboxTags }) => { | |||
There was a problem hiding this comment.
Can you find a better name than netboxTags?
Also, it make the code a bit harder to understand with cluster vs netboxTags.
There was a problem hiding this comment.
I'm trying to differentiate Netbox objects from XO objects even when there's no variable name conflict (tag vs netboxTag). But when the object type was already different, I didn't namespace them (pool vs cluster). But maybe I should? And maybe I should also namespace XO objects?
There was a problem hiding this comment.
I'm not sure, maybe always prefixing objects with xo and nb would make the code clearer 🤔
What do you think?
There was a problem hiding this comment.
Yes, I like it. It might be a bit verbose but at least it's clear and consistent.
julien-f
reviewed
Aug 7, 2023
pdonias
force-pushed
the
pierre-netbox-sync-tags
branch
from
274f7d6 to
df97d22
Compare
julien-f
reviewed
Aug 8, 2023
julien-f
force-pushed
the
pierre-netbox-sync-tags
branch
from
df97d22 to
439a1df
Compare
julien-f
force-pushed
the
pierre-netbox-sync-tags
branch
from
439a1df to
54b633f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SQUASH!
Fixes #5899
See Zammad#12478
See https://xcp-ng.org/forum/topic/6902
Screenshots
Description
Synchronize XO VM tags with Netbox VM tags.
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md