Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-server/xostor): bind a XOSTOR with a license at the XOSTOR creation #7015

Merged
merged 5 commits into from
Oct 24, 2023
Merged

feat(xo-server/xostor): bind a XOSTOR with a license at the XOSTOR creation #7015

merged 5 commits into from
Oct 24, 2023

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Sep 4, 2023 •
edited
Loading

Description

⚠ Wait MR#129 before merging ⚠

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this Sep 4, 2023
@MathieuRA MathieuRA changed the title feat(xo-server/xostor): associate a XOSTOR with a license at the XOSTOR creation feat(xo-server/xostor): bind a XOSTOR with a license at the XOSTOR creation Sep 4, 2023
@MathieuRA MathieuRA requested a review from ggunullu September 4, 2023 13:02
@MathieuRA MathieuRA requested review from fbeauchamp and removed request for ggunullu September 25, 2023 09:47
@fbeauchamp fbeauchamp requested a review from julien-f September 27, 2023 09:59
julien-f
julien-f requested changes Sep 28, 2023
View reviewed changes
packages/xo-server/src/api/xostor.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/api/xostor.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/api/xostor.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/api/xostor.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/api/xostor.mjs Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from julien-f October 10, 2023 08:57
@MathieuRA MathieuRA requested a review from julien-f October 20, 2023 13:28
@MathieuRA MathieuRA marked this pull request as ready for review October 23, 2023 12:30
@julien-f julien-f merged commit 8260f27 into xostor/master Oct 24, 2023
1 check passed
@julien-f julien-f deleted the xostor/licenses branch October 24, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f julien-f approved these changes

@fbeauchamp fbeauchamp fbeauchamp approved these changes

Assignees

@MathieuRA MathieuRA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MathieuRA @fbeauchamp @julien-f