Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix host_smartReboot when VMs have a suspended operation block #7025

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Fix host_smartReboot when VMs have a suspended operation block #7025

merged 2 commits into from
Oct 6, 2023

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Sep 7, 2023 •
edited
Loading

Screenshot

Capture d’écran de 2023-09-29 15-00-09
Capture d’écran de 2023-10-03 16-22-23

Description

Do not squash

See XCP-ng forum#7136

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this Sep 7, 2023
@MathieuRA MathieuRA force-pushed the xo5/smart-reboot-bypass branch from 2dc83bd to 11787bc Compare September 7, 2023 15:02
@MathieuRA MathieuRA force-pushed the xo5/smart-reboot-bypass branch from 11787bc to 02016d2 Compare September 7, 2023 15:17
@MathieuRA MathieuRA marked this pull request as ready for review September 8, 2023 07:43
Rajaa-BARHTAOUI
Rajaa-BARHTAOUI reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't forget to fix the PR title

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/host/tab-advanced.js Outdated Show resolved Hide resolved
pdonias
pdonias requested changes Sep 25, 2023
View reviewed changes
@xen-orchestra/xapi/host.mjs Outdated Show resolved Hide resolved
@xen-orchestra/xapi/host.mjs Outdated Show resolved Hide resolved
@xen-orchestra/xapi/host.mjs Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/host/tab-advanced.js Outdated Show resolved Hide resolved
@Rajaa-BARHTAOUI Rajaa-BARHTAOUI requested review from pdonias and removed request for Rajaa-BARHTAOUI September 26, 2023 12:28
@MathieuRA MathieuRA requested a review from pdonias September 27, 2023 07:27
pdonias
pdonias requested changes Sep 27, 2023
View reviewed changes
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias September 27, 2023 08:37
pdonias
pdonias requested changes Sep 27, 2023
View reviewed changes
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias September 27, 2023 09:02
@pdonias pdonias requested a review from julien-f September 27, 2023 09:42
julien-f
julien-f reviewed Sep 27, 2023
View reviewed changes
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from julien-f September 27, 2023 14:57
@MathieuRA MathieuRA requested a review from julien-f September 27, 2023 15:22
@julien-f julien-f removed their request for review September 27, 2023 15:40
@MathieuRA MathieuRA requested a review from julien-f September 27, 2023 15:47
julien-f
julien-f reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please rebase on master and clean up the history if you don't want me to squash.

@MathieuRA MathieuRA force-pushed the xo5/smart-reboot-bypass branch 2 times, most recently from 42ed04b to 2a86107 Compare September 27, 2023 16:10
@MathieuRA MathieuRA requested a review from julien-f September 27, 2023 16:19
@MathieuRA MathieuRA requested review from julien-f and removed request for julien-f September 28, 2023 06:10
@MathieuRA MathieuRA force-pushed the xo5/smart-reboot-bypass branch from 5dae160 to ca0f674 Compare September 29, 2023 09:18
@MathieuRA MathieuRA requested a review from julien-f September 29, 2023 13:02
@julien-f julien-f requested a review from pdonias September 29, 2023 13:11
julien-f
julien-f approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pdonias
pdonias requested changes Oct 3, 2023
View reviewed changes
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias October 3, 2023 14:23
pdonias
pdonias requested changes Oct 4, 2023
View reviewed changes
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias October 5, 2023 08:39
@MathieuRA MathieuRA force-pushed the xo5/smart-reboot-bypass branch from 40b2012 to 69e4821 Compare October 6, 2023 14:25
@pdonias pdonias merged commit 549d9b7 into master Oct 6, 2023
@pdonias pdonias deleted the xo5/smart-reboot-bypass branch October 6, 2023 14:52
@Danp2 Danp2 mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI Rajaa-BARHTAOUI left review comments

@pdonias pdonias pdonias approved these changes

@julien-f julien-f julien-f approved these changes

Assignees

@MathieuRA MathieuRA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MathieuRA @julien-f @Rajaa-BARHTAOUI @pdonias