-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(xo-web/kubernetes): remove required property from search domain #7028
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it working correctly?
What is sent to the server if the field is empty?
Yes, it works correctly.
|
@ggunullu Are you sure? What if the user types in the field and then clears it? |
You're right it wouldn't work, I hadn't thought about this scenario. I'll correct that. |
252a4f2
to
e946806
Compare
7666a85
to
cd45edb
Compare
c6e4626
to
405e924
Compare
Make this field optional for the cluster creation.
da764ef
to
a22b654
Compare
To merge alongside with https://gitlab.com/vates/xoa/-/merge_requests/130
Description
Short explanation of this PR (feel free to re-use commit message)
Checklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md