Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/kubernetes): remove required property from search domain #7028

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

ggunullu
Copy link
Contributor

@ggunullu ggunullu commented Sep 8, 2023

To merge alongside with https://gitlab.com/vates/xoa/-/merge_requests/130

Description

Short explanation of this PR (feel free to re-use commit message)

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@ggunullu ggunullu requested a review from MathieuRA September 8, 2023 18:28
@MathieuRA MathieuRA requested review from pdonias and julien-f and removed request for pdonias September 11, 2023 09:48
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it working correctly?

What is sent to the server if the field is empty?

@ggunullu
Copy link
Contributor Author

Is it working correctly?

What is sent to the server if the field is empty?

Yes, it works correctly.

undefined is sent to the server if the field is empty. Actually, on the server side, this parameter was already optional if the user chose dynamic network configuration for the cluster.

@julien-f
Copy link
Member

@ggunullu Are you sure? What if the user types in the field and then clears it?

@ggunullu
Copy link
Contributor Author

@ggunullu Are you sure? What if the user types in the field and then clears it?

You're right it wouldn't work, I hadn't thought about this scenario. I'll correct that.

@ggunullu ggunullu force-pushed the gab-k8s-seach_optional branch from 252a4f2 to e946806 Compare September 18, 2023 17:14
@ggunullu ggunullu requested a review from julien-f September 18, 2023 17:39
@ggunullu ggunullu force-pushed the gab-k8s-seach_optional branch from 7666a85 to cd45edb Compare September 19, 2023 19:28
@ggunullu ggunullu requested a review from julien-f September 19, 2023 19:46
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@ggunullu ggunullu force-pushed the gab-k8s-seach_optional branch from c6e4626 to 405e924 Compare September 22, 2023 02:23
Make this field optional for the cluster creation.
@ggunullu ggunullu force-pushed the gab-k8s-seach_optional branch from da764ef to a22b654 Compare September 22, 2023 02:29
@ggunullu ggunullu requested review from julien-f and removed request for julien-f September 22, 2023 02:30
@julien-f julien-f merged commit 1eb4c20 into master Sep 22, 2023
@julien-f julien-f deleted the gab-k8s-seach_optional branch September 22, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants