Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xo-server): add mbr for cloud-init only for windows VM #7050

Merged
merged 3 commits into from
Sep 28, 2023
Merged

fix(xo-server): add mbr for cloud-init only for windows VM #7050

merged 3 commits into from
Sep 28, 2023

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Sep 21, 2023 •
edited
Loading

Description

Kaleos use a minimal boot loader that don't like he MBR introduced by #6889

This PR try to add MBR only for windows template, by using the viridian flag in the platform property

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp fbeauchamp force-pushed the fix_cloudinit_mbr_non_windows branch from eda315d to c3e5520 Compare September 21, 2023 12:26
@fbeauchamp fbeauchamp marked this pull request as ready for review September 21, 2023 12:56
@fbeauchamp fbeauchamp requested a review from julien-f September 27, 2023 09:38
@fbeauchamp fbeauchamp requested a review from julien-f September 27, 2023 14:16
@julien-f julien-f changed the title fix(xo-server): add mbr for cloud init only for windows VM fix(xo-server): add mbr for cloud-init only for windows VM Sep 27, 2023
julien-f
julien-f requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts with master.

@fbeauchamp fbeauchamp force-pushed the fix_cloudinit_mbr_non_windows branch from 5ae46c9 to f2c26f5 Compare September 28, 2023 06:42
@fbeauchamp fbeauchamp requested a review from julien-f September 28, 2023 06:43
@julien-f julien-f merged commit 988179a into master Sep 28, 2023
@julien-f julien-f deleted the fix_cloudinit_mbr_non_windows branch September 28, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f Awaiting requested review from julien-f

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbeauchamp @julien-f