fix(netbox/VM): explicitly assign site #7124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdonias
force-pushed
the
pierre-fix-netbox-vm-site
branch
2 times, most recently
from
5b3ae27 to
c545a05
Compare
See Zammad#17766 See https://xcp-ng.org/forum/topic/7887
pdonias
force-pushed
the
pierre-fix-netbox-vm-site
branch
from
c545a05 to
3112c85
Compare
pdonias
force-pushed
the
pierre-fix-netbox-vm-site
branch
from
6acc632 to
0ec5ac8
Compare
MathieuRA
approved these changes
Oct 26, 2023
julien-f
reviewed
Oct 30, 2023
| @@ -395,6 +402,7 @@ class Netbox { | |||
| cluster: nbVm.cluster?.id ?? null, | |||
| status: nbVm.status?.value ?? null, | |||
| platform: nbVm.platform?.id ?? null, | |||
| site: nbVm.site === undefined ? undefined : nbVm.site?.id ?? null, | |||
There was a problem hiding this comment.
Simplify or remove ? in nbVm.site?.id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Zammad#17766
See https://xcp-ng.org/forum/topic/7887
Description
Assign
sitefield to VMs on versions of Netbox where it's mandatory.Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md