Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server/PIF): call PIF.forget to delete PIF #7221

Merged
merged 7 commits into from
Dec 18, 2023
Merged

fix(xo-server/PIF): call PIF.forget to delete PIF #7221

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d5ac10a
bugfix(xo-server/host/network): Can't remove PIF
MelissaFrncJrg Dec 6, 2023
1181140
add changelog entry
MelissaFrncJrg Dec 6, 2023
d253a11
Merge branch 'master' into bugfixPIF
MelissaFrncJrg Dec 6, 2023
ea4fff5
Merge branch 'master' into bugfixPIF
MelissaFrncJrg Dec 7, 2023
88bfac5
Merge branch 'master' into bugfixPIF
MelissaFrncJrg Dec 11, 2023
45d96bc
Update CHANGELOG.unreleased.md
pdonias Dec 18, 2023
f265500
Merge branch 'master' into bugfixPIF
pdonias Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
> Users must be able to say: “I had this issue, happy to know it's fixed”

- [REST API] Returns a proper 404 _Not Found_ error when a job does not exist instead of _Internal Server Error_
- [Remove PIF] Removing NIC in network tab of a host generated an error "PIF_IS_PHYSICAL" [#7193](https://github.com/vatesfr/xen-orchestra/issues/7193) (PR[7221](https://github.com/vatesfr/xen-orchestra/pull/7221))
pdonias marked this conversation as resolved.
Show resolved Hide resolved

### Packages to release

Expand Down
2 changes: 1 addition & 1 deletion packages/xo-server/src/api/pif.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ async function delete_({ pif }) {
return
}

await xapi.callAsync('PIF.destroy', pif._xapiRef)
await xapi.callAsync('PIF.forget', pif._xapiRef)
julien-f marked this conversation as resolved.
Show resolved Hide resolved
}
export { delete_ as delete }

Expand Down
Loading