Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xo-web/backup): fix reportWhen being reset to undefined #7235

Merged
merged 5 commits into from
Dec 19, 2023
Merged

fix(xo-web/backup): fix reportWhen being reset to undefined #7235

merged 5 commits into from
Dec 19, 2023

Conversation

b-Nollet
Copy link
Contributor

@b-Nollet b-Nollet commented Dec 12, 2023 •
edited by pdonias
Loading

See Zammad#17506

Description

Preventing reportWhen value from becoming undefined (and resetting to the default value Failure) when a mirror backup is edited without modifying this field.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@b-Nollet b-Nollet requested a review from pdonias December 12, 2023 09:22
@pdonias pdonias self-requested a review December 14, 2023 09:03
@pdonias
Copy link
Member

pdonias commented Dec 19, 2023

@b-Nollet Do you want to add a Changelog entry? If the change is visible by users, it's better to add one.

@b-Nollet
Copy link
Contributor Author

@b-Nollet Do you want to add a Changelog entry? If the change is visible by users, it's better to add one.

Done :)

pdonias
pdonias requested changes Dec 19, 2023
View reviewed changes
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@b-Nollet b-Nollet requested a review from pdonias December 19, 2023 15:35
pdonias
pdonias requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To help us track where the change comes from, mention the source of the request at the top of the PR description. In this case:

See Zammad#17506

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@b-Nollet @pdonias
Simpler changelog message
33466c8 
Co-authored-by: Pierre Donias <[email protected]>
@b-Nollet b-Nollet requested a review from pdonias December 19, 2023 15:56
@pdonias pdonias changed the title fix: backup reportWhen reset fix(xo-web/backup): fix reportWhen being reset to undefined Dec 19, 2023
@pdonias pdonias merged commit c40e71e into master Dec 19, 2023
1 check passed
@pdonias pdonias deleted the fix-backup-reportWhen branch December 19, 2023 16:08
pdonias added a commit that referenced this pull request Dec 21, 2023
@pdonias
fix(CHANGELOG): more specific description for mirror backup report fix
23d7e81 
Introduced by #7235
See #7235 (comment)
@pdonias pdonias mentioned this pull request Dec 21, 2023
Merged
julien-f pushed a commit that referenced this pull request Dec 21, 2023
@pdonias
fix(CHANGELOG): more specific description for mirror backup report fix (
b7b7af8 
#7253)

Introduced by #7235
See #7235 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f julien-f left review comments

@pdonias pdonias pdonias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b-Nollet @pdonias @julien-f