Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web/pool): ability to do a rolling pool reboot #7243

Merged
merged 7 commits into from
Jan 26, 2024
Merged

feat(xo-web/pool): ability to do a rolling pool reboot #7243

merged 7 commits into from
Jan 26, 2024

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Dec 19, 2023 •
edited
Loading

Screenshots

Capture d’écran de 2024-01-11 16-40-23
Capture d’écran de 2024-01-11 16-39-33

Description

wait for the PR #7242
Fixes #6885

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this Dec 19, 2023
@MathieuRA MathieuRA requested a review from fbeauchamp December 19, 2023 08:56
fbeauchamp
fbeauchamp requested changes Dec 19, 2023
View reviewed changes
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from fbeauchamp December 19, 2023 16:53
@MathieuRA MathieuRA requested a review from pdonias December 20, 2023 09:55
pdonias
pdonias requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a screenshot of the modal too, please?

packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested review from pdonias and removed request for pdonias January 11, 2024 15:43
pdonias
pdonias approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge after #7242.

@MathieuRA MathieuRA force-pushed the xo5/rolling_pool_reboot_ui branch from e3f51cd to 819b2b7 Compare January 26, 2024 14:02
@MathieuRA MathieuRA marked this pull request as ready for review January 26, 2024 14:02
@MathieuRA
Copy link
Member Author

@pdonias Ready to merge

@pdonias
Copy link
Member

pdonias commented Jan 26, 2024

@MathieuRA The code was good for me so if it's tested on top of the other PR then, yes.

@pdonias pdonias merged commit 0c02510 into master Jan 26, 2024
1 check passed
@pdonias pdonias deleted the xo5/rolling_pool_reboot_ui branch January 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdonias pdonias pdonias approved these changes

@fbeauchamp fbeauchamp fbeauchamp approved these changes

Assignees

@MathieuRA MathieuRA

Labels
Highlight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pool Rolling Reboot
3 participants
@MathieuRA @pdonias @fbeauchamp