Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web): scoped tags #7270

Merged
merged 5 commits into from
Dec 28, 2023
Merged

feat(xo-web): scoped tags #7270

merged 5 commits into from
Dec 28, 2023

Conversation

julien-f
Copy link
Member

@julien-f julien-f commented Dec 28, 2023 •
edited
Loading

Description

Based on #7258 developed by @fbeauchamp.

  • use inline blocks to respect all paddings/margins
  • main settings are in easily modifiable variables
  • text color is either black or white based on the background color luminance
  • make sure tags and surrounding action buttons are aligned

Home view:
image

VM view:
image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@julien-f
feat(xo-web): scoped tags
5ffec1d 
Based on #7258 developed by @fbeauchamp.

- use inline blocks to respect all paddings/margins
- main settings are in easily modifiable variables
- text color is either black or white based on the background color luminance
- make sure tags and surrounding action buttons are aligned
@julien-f julien-f requested a review from MathieuRA December 28, 2023 15:35
@julien-f
cross same color as scoped value
a5486f1
@julien-f
changelog
392d9f3
@julien-f
thicker border
1d5eded
@julien-f
various
f40a66a 
- remove border between scoped value and delete button
- always display value in black on white
- delete button use tag color if dark, otherwise black
- Tag component accept color param
@julien-f julien-f mentioned this pull request Dec 28, 2023
Closed
@julien-f julien-f merged commit 2c40b99 into master Dec 28, 2023
1 check passed
@julien-f julien-f deleted the jft-scoped branch December 28, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathieuRA MathieuRA MathieuRA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-f @MathieuRA