Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-server/signin): remember me with external providers #7298

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

julien-f
Copy link
Member

@julien-f julien-f commented Jan 10, 2024

DO NOT SQUASH, review by commit.

Description

It works the same as password signin.

Before:

image

After:

image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Make sign in with password button the same as external providers.
@julien-f julien-f force-pushed the auth-providers-remember-me branch from 947bbc2 to 6c9eea5 Compare January 11, 2024 08:00
@julien-f julien-f marked this pull request as ready for review January 11, 2024 08:11
@julien-f julien-f requested a review from b-Nollet January 11, 2024 08:12
@julien-f julien-f requested a review from pdonias January 11, 2024 09:12
@pdonias pdonias merged commit 7946a7d into master Jan 16, 2024
1 check passed
@pdonias pdonias deleted the auth-providers-remember-me branch January 16, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants