feat(xo-web,backups): fix dynamic disks count with suspend_VDI #7315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeauchamp
force-pushed
the
feat_incremental_with_memory
branch
from
4a6e764 to
c154dea
Compare
b-Nollet
approved these changes
Jan 17, 2024
julien-f
requested changes
Jan 18, 2024
fbeauchamp
force-pushed
the
feat_incremental_with_memory
branch
from
c154dea to
c914acc
Compare
fbeauchamp
force-pushed
the
feat_incremental_with_memory
branch
from
c914acc to
cd9c0f2
Compare
julien-f
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Memory ( suspend_vdi) is counted as a full when showing how many incremental/key disks a backup contains
This PR ignore it in the computation, but add a tag if the backup is with memory
review by commit, do not squash
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md