Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server/host): fix false positives when restarting host after updates #7366

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Feb 9, 2024

Description

The previous implementation only considered version upgrades and did not take into account the installation of missing patches.

See zammad#21487
Introduced by 85ec261

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this Feb 9, 2024
@MathieuRA MathieuRA requested a review from fbeauchamp February 9, 2024 09:33
packages/xo-server/src/api/host.mjs Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from fbeauchamp February 13, 2024 10:49
@MathieuRA MathieuRA requested a review from julien-f February 14, 2024 16:43
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this code needed a fix, it likely means that it was not trivial, which means that some comments are required.

If the comments are not enough to describe the issue/fix itself, please add more explanation in the PR/commit message.

@MathieuRA MathieuRA requested a review from julien-f February 19, 2024 09:15
@julien-f julien-f force-pushed the xo5/fix-host-reboot-false-positive branch from dc0894b to 31d8c29 Compare February 21, 2024 14:01
@julien-f julien-f merged commit 039d568 into master Feb 21, 2024
1 check passed
@julien-f julien-f deleted the xo5/fix-host-reboot-false-positive branch February 21, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants