-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(xo-server/host): fix false positives when restarting host after updates #7366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeauchamp
requested changes
Feb 9, 2024
fbeauchamp
approved these changes
Feb 14, 2024
julien-f
reviewed
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this code needed a fix, it likely means that it was not trivial, which means that some comments are required.
If the comments are not enough to describe the issue/fix itself, please add more explanation in the PR/commit message.
julien-f
reviewed
Feb 21, 2024
julien-f
reviewed
Feb 21, 2024
Co-authored-by: Julien Fontanet <[email protected]>
Co-authored-by: Julien Fontanet <[email protected]>
julien-f
force-pushed
the
xo5/fix-host-reboot-false-positive
branch
from
February 21, 2024 14:01
dc0894b
to
31d8c29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous implementation only considered version upgrades and did not take into account the installation of missing patches.
See zammad#21487
Introduced by 85ec261
Checklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md