Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server): support of cloudbase-init #8154

Merged
merged 4 commits into from
Nov 26, 2024
Merged

fix(xo-server): support of cloudbase-init #8154

merged 4 commits into from
Nov 26, 2024

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Nov 22, 2024

Description

Related to zammad #30594
See: natevw/fatfs#30 and natevw/fatfs#31
The fatfs library has been forked to implement the createLabel function, which is required otherwise the disk is mounted without label (for windows VMs at least).
Necessary for Cloudbase-Init.

Cloudbase-Init test

  • New -> VM.
  • Select XCP 8.3.0 XO Team pool
  • Select Windows Server 2019 (64-bit) (Cloudbase init) as template
  • Check Custom config
  • Copy/Past this config in User config (You also can create your own config)
#cloud-config
write_files:
   encoding: b64
   content: NDI=
   path: C:\test
   permissions: '0o466'
  • Create the VM
  • Wait for the VM to boot (you will need to setup a password for your VM)
  • Go to / with cd /
  • List with dir
  • You should see a file named test. (file created by the cloud-config defined above)
  • To read the content of the file: more test (output 42)

You also can create your own template!

...
config_drive_vfat=true
...
metadata_services=cloudbaseinit.metadata.services.nocloudservice.NoCloudConfigDriveService
plugins=cloudbaseinit.plugins.common.userdata.UserDataPlugin
...
  • Shutdown
  • Convert to template

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@MathieuRA MathieuRA force-pushed the fix-fs-label branch 2 times, most recently from cc1538a to 91cde20 Compare November 22, 2024 14:33
@MathieuRA MathieuRA self-assigned this Nov 22, 2024
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is broken, you likely need to configure ESLint to ignore this package.

Copy link
Collaborator

@fbeauchamp fbeauchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either fix the package or ignore it through an eslint rule
(if the changes are only let/const var and some syntaxic sugar, I would prefer a fix as a separate commits
import package
eslint rule
add new feature

@MathieuRA MathieuRA dismissed julien-f’s stale review November 26, 2024 09:01

comment resolved

@MathieuRA MathieuRA merged commit a22e4a6 into master Nov 26, 2024
1 check failed
@MathieuRA MathieuRA deleted the fix-fs-label branch November 26, 2024 09:01
@olivierlambert
Copy link
Member

Can I assume it will be available for the next release?

@MathieuRA
Copy link
Member Author

MathieuRA commented Nov 27, 2024

Can I assume it will be available for the next release?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants