-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(xo-server): support of cloudbase-init #8154
Conversation
cc1538a
to
91cde20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is broken, you likely need to configure ESLint to ignore this package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either fix the package or ignore it through an eslint rule
(if the changes are only let/const var and some syntaxic sugar, I would prefer a fix as a separate commits
import package
eslint rule
add new feature
e48901e
to
ed454e8
Compare
Can I assume it will be available for the next release? |
Yes |
Description
Related to zammad #30594
See: natevw/fatfs#30 and natevw/fatfs#31
The
fatfs
library has been forked to implement thecreateLabel
function, which is required otherwise the disk is mounted without label (for windows VMs at least).Necessary for Cloudbase-Init.
Cloudbase-Init test
XCP 8.3.0 XO Team
poolWindows Server 2019 (64-bit) (Cloudbase init)
as templateCustom config
/
withcd /
dir
test
. (file created by the cloud-config defined above)more test
(output42
)You also can create your own template!
Run Sysprep
cloudbase-init-unattend.conf
with at least these 3 thingsChecklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md
Review process
Notes: