Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed injectName helper #720

Merged
merged 1 commit into from
May 20, 2020
Merged

Removed injectName helper #720

merged 1 commit into from
May 20, 2020

Conversation

radekmie
Copy link
Contributor

@radekmie radekmie commented May 9, 2020

As said in #717, there are different types of fields. A long time ago, a new injectName helper got introduced as NestField couldn't use context for context propagation due to the problems with blocking updates (more about it is in #716). This change simplifies NestField and removes the injectName helper completely.

This is a first step of removing includeInChain option of connectField. The only field that still uses it is the ListField, but it'd require one more change (more about it soon).

@radekmie radekmie requested review from kestarumper and Monteth May 9, 2020 11:03
@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #720 into v3 will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #720      +/-   ##
==========================================
- Coverage   97.99%   97.98%   -0.01%     
==========================================
  Files         159      158       -1     
  Lines        1645     1640       -5     
  Branches      598      597       -1     
==========================================
- Hits         1612     1607       -5     
  Misses          8        8              
  Partials       25       25              
Impacted Files Coverage Δ
packages/uniforms-antd/src/NestField.tsx 100.00% <100.00%> (ø)
packages/uniforms-bootstrap3/src/NestField.tsx 100.00% <100.00%> (ø)
packages/uniforms-bootstrap4/src/NestField.tsx 100.00% <100.00%> (ø)
packages/uniforms-material/src/NestField.tsx 100.00% <100.00%> (ø)
packages/uniforms-semantic/src/NestField.tsx 100.00% <100.00%> (ø)
packages/uniforms-unstyled/src/NestField.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed1ad0a...f69d9fc. Read the comment docs.

@radekmie radekmie added the Type: Feature New features and feature requests label May 9, 2020
@radekmie radekmie added this to the v3 milestone May 9, 2020
@radekmie radekmie mentioned this pull request May 9, 2020
@radekmie radekmie merged commit 36fe72b into v3 May 20, 2020
@radekmie radekmie deleted the v3-removed-injectname branch May 20, 2020 11:16
@radekmie radekmie mentioned this pull request Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants