don't add a padding entry if it has no bytes #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference #65 Signed-off-by: Vincent Batts <[email protected]>
Fixes #65 if the read bytes is 0, then don't even create the entry for that padding. This sounds like the solution for the issue opened, but I haven't found a reproducer for this issue yet. :-\ Signed-off-by: Vincent Batts <[email protected]>
|
all green |
|
Hmm zero bytes; some of the tags in my |
mtrmac
reviewed
Jul 21, 2023
| @@ -135,6 +135,9 @@ func NewInputTarStream(r io.Reader, p storage.Packer, fp storage.FilePutter) (io | |||
| } | |||
| isEOF = true | |||
| } | |||
| if n == 0 { | |||
| break | |||
There was a problem hiding this comment.
https://pkg.go.dev/io#Reader says
Callers should treat a return of 0 and nil as indicating that nothing happened; in particular it does not indicate EOF.
so I think this should, pedantically, be
if n != 0 {
if _, err := AddEntry(…); err != nil { fail }
}letting isEOF break the loop, but continuing to the next iteration on Read returning 0, nil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
If the read bytes is 0, then don't even create the entry for that padding.
This sounds like the solution for the issue opened, but I haven't found a reproducer for this issue yet. :-\