fix: validate message not display, fix #5034

[mynetfan]

Description

修复表单校验信息不显示的问题, fix #5034 , fix #5056

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• Bug Fixes

  • Streamlined layout of form fields by simplifying the wrapping div element.
  • Improved class binding for the FormControl component for better clarity.

• Refactor

  • Enhanced the structure and logic of form component rendering without impacting core functionality.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 38c831c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Warning

Rate limit exceeded

@anncwb has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 28 minutes and 21 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between c5bd64a and 38c831c.

📒 Files selected for processing (1)

• packages/@core/ui-kit/form-ui/src/form-render/form-field.vue (1 hunks)

Walkthrough

The changes in this pull request focus on the form-field.vue file, where the template structure and rendering logic for form components have been simplified. Key modifications include the removal of the overflow-hidden class from the wrapping div and a more concise class binding for the FormControl component. The encapsulation of component properties has been improved through the createComponentProps function, while validation logic and event bindings remain unchanged.

Changes

File Path	Change Summary
packages/@core/ui-kit/form-ui/src/form-render/form-field.vue	Simplified template structure, removed overflow-hidden class, streamlined FormControl class binding, and improved createComponentProps function. Validation logic and event bindings retained.

Possibly related PRs

• fix: form required style adjustment #4668: This PR modifies the form-field.vue component, focusing on the template and computed properties, which directly relates to the changes made in the same file in the main PR.
• fix: select Long option style problem #5030: This PR also addresses changes in form-field.vue, specifically enhancing the styling of the FormControl component, which aligns with the modifications described in the main PR.

Suggested labels

bug

Suggested reviewers

• anncwb
• vince292007

🐇 In the fields where bunnies play,
A form was spruced up in a clever way.
With classes trimmed and props refined,
The code is neat, and all aligned.
Hooray for forms, so bright and clear,
Let’s hop along, there’s nothing to fear! 🐰

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

packages/@core/ui-kit/form-ui/src/form-render/form-field.vue (1)

Line range hint 339-341: Consider improving the validation message transition.

The current implementation might cause layout shifts during the transition. Consider these improvements:

1. Add a fixed height container for the validation message
2. Use transform-based transitions for better performance

-        <Transition name="slide-up">
-          <FormMessage class="absolute -bottom-[22px]" />
-        </Transition>
+        <div class="h-6 relative">
+          <Transition
+            enter-active-class="transform transition duration-200 ease-out"
+            enter-from-class="opacity-0 translate-y-1"
+            enter-to-class="opacity-100 translate-y-0"
+            leave-active-class="transform transition duration-200 ease-in"
+            leave-from-class="opacity-100 translate-y-0"
+            leave-to-class="opacity-0 translate-y-1"
+          >
+            <FormMessage class="absolute" />
+          </Transition>
+        </div>

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 21d37a1 and c5bd64a.

📒 Files selected for processing (1)

• packages/@core/ui-kit/form-ui/src/form-render/form-field.vue (1 hunks)

🔇 Additional comments (1)

packages/@core/ui-kit/form-ui/src/form-render/form-field.vue (1)

301-301: LGTM! This change fixes the validation message visibility issue.

The removal of overflow-hidden from the wrapper div allows the absolutely positioned validation message to be visible outside its container. This directly addresses issue #5034 where validation messages were not being displayed.

[DesignHhuang]

还是会存在 #5029 的问题
并且 验证错误提示很长的话，也会又样式问题， 并非最佳方案