fix: 修复Form表单开启submitOnChange、submitOnEnter后配置fieldMappingTime的数组值映射字… #5328
Conversation
Dengjunle
requested review from
anncwb,
vince292007 and
mynetfan
as code owners
|
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/@core/ui-kit/form-ui/src/form-api.tsOops! Something went wrong! :( ESLint: 9.17.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs WalkthroughThe pull request introduces a new method Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/@core/ui-kit/form-ui/src/form-api.ts(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: post-update (windows-latest)
- GitHub Check: post-update (ubuntu-latest)
🔇 Additional comments (2)
packages/@core/ui-kit/form-ui/src/form-api.ts (2)
18-18: LGTM: Import addition is appropriateThe addition of
formatDateimport is correctly placed and necessary for the new time range handling functionality.
101-137: Verify time range handling across all form submission scenariosPlease ensure comprehensive testing of the following scenarios:
- Form submission with
submitOnChangeenabled- Form submission with
submitOnEnterenabled- Multiple time range fields in a single form
- Different format configurations for start and end times
Run the following script to find all form submission trigger points:
✅ Verification successful
Time range handling implementation is correct and comprehensive
The implementation properly handles all form submission scenarios:
- Correctly processes null/undefined values
- Supports custom date formats for start/end times
- Properly cleans up fields during form reset
- Works with all form submission triggers (onChange, onEnter, manual submit)
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Find all form submission related code echo "Searching for form submission triggers..." rg -l "submitOnChange|submitOnEnter|handleSubmit|submitForm" echo "Searching for time range field usage..." rg -l "fieldMappingTime|handleRangeTimeValue"Length of output: 2868
Script:
#!/bin/bash # Check form-actions.vue implementation echo "=== Form Actions Implementation ===" cat "packages/@core/ui-kit/form-ui/src/components/form-actions.vue" echo -e "\n=== Basic Form Example ===" cat "playground/src/views/examples/form/basic.vue" echo -e "\n=== Type Definitions ===" cat "packages/@core/ui-kit/form-ui/src/types.ts"Length of output: 23617
Description
Type of change
Please delete options that are not relevant.
pnpm-lock.yamlunless you introduce a new test example.Checklist
pnpm run docs:devcommand.pnpm test.feat:,fix:,perf:,docs:, orchore:.Summary by CodeRabbit