fix(@vben/turbo-run): fix update @clack/prompts 0.7.0 -> 0.9.1 typescript error #5444
Conversation
Mask-MJ
requested review from
anncwb,
vince292007 and
mynetfan
as code owners
|
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
scripts/turbo-run/src/run.tsOops! Something went wrong! :( ESLint: 9.17.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs WalkthroughThe pull request introduces a modification to the Changes
Suggested Reviewers
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
scripts/turbo-run/src/run.ts (2)
Line range hint
36-39: Add type guard for selectPkgThe type checking for
selectPkgcould be more robust. Consider adding a type guard to ensure type safety.- if (isCancel(selectPkg) || !selectPkg) { + if (isCancel(selectPkg)) { cancel('👋 Has cancelled'); process.exit(0); } + if (!selectPkg || typeof selectPkg !== 'string') { + console.error('Invalid selection'); + process.exit(1); + }
Line range hint
41-42: Consider explicit type annotation for single package selectionWhen there's only one package, the type safety could be improved.
- selectPkg = selectPkgs[0]?.packageJson?.name ?? ''; + const pkgName = selectPkgs[0]?.packageJson?.name; + selectPkg = typeof pkgName === 'string' ? pkgName : '';
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
scripts/turbo-run/src/run.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: Lint (windows-latest)
- GitHub Check: Check (windows-latest)
- GitHub Check: Lint (ubuntu-latest)
- GitHub Check: post-update (windows-latest)
- GitHub Check: Test (windows-latest)
- GitHub Check: post-update (ubuntu-latest)
- GitHub Check: Check (ubuntu-latest)
- GitHub Check: Test (ubuntu-latest)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
scripts/turbo-run/src/run.ts (1)
Line range hint
28-34: Verify type safety with @clack/prompts v0.9.1The removal of explicit type annotations might affect type safety. Let's verify if this change aligns with the library's API changes.
Consider adding type annotations to maintain type safety:
- selectPkg = await select({ + selectPkg = await select<string>({ message: `Select the app you need to run [${command}]:`, options: selectPkgs.map((item) => ({ label: item?.packageJson.name, value: item?.packageJson.name, })), });
Description
Type of change
Please delete options that are not relevant.
pnpm-lock.yamlunless you introduce a new test example.Checklist
pnpm run docs:devcommand.pnpm test.feat:,fix:,perf:,docs:, orchore:.Summary by CodeRabbit