Add Search_Config validation (#2811) (#2817)

* add Search_Config validation

* change to error function and generate individual errors

* add search configuration

Co-authored-by: Kosuke Morimoto <[email protected]>
Co-authored-by: Kiichiro YUKAWA <[email protected]>

internal/errors/lb.go

@@ -25,4 +25,9 @@ var (
 
 	// ErrIndexNotFound represents an error that the index not found.
 	ErrIndexNotFound = New("index not found")
+
+	// ErrInvalidSearchConfig represents an error that the invalid Search Configuration.
+	ErrInvalidSearchConfig = func(msg string) error {
+		return Errorf("Invalid Search_Config: %s", msg)
+	}
 )

pkg/gateway/lb/handler/grpc/aggregation.go

@@ -65,6 +65,10 @@ func (s *server) aggregationSearch(
 		}
 	}()
 
+	if bcfg == nil {
+		return nil, nil, errors.ErrInvalidSearchConfig("bcfg is nil in aggregationSearch")
+	}
+
 	num := aggr.GetNum()
 	min := int(bcfg.GetMinNum())
 

pkg/gateway/lb/handler/grpc/handler.go

@@ -438,6 +438,28 @@ func (s *server) doSearch(
 		}
 	}()
 
+	if cfg == nil {
+		err = errors.ErrInvalidSearchConfig("search config is nil in doSearch")
+		err = status.WrapWithInvalidArgument(apiName+"/doSearch", err, &errdetails.RequestInfo{
+			RequestId:   "Search_Config is nil",
+			ServingData: "Search_Config is nil",
+		},
+			&errdetails.BadRequest{
+				FieldViolations: []*errdetails.BadRequestFieldViolation{
+					{
+						Field:       "Search_Config is nil",
+						Description: err.Error(),
+					},
+				},
+			})
+		if span != nil {
+			span.RecordError(err)
+			span.SetAttributes(trace.StatusCodeInvalidArgument(err.Error())...)
+			span.SetStatus(trace.StatusError, err.Error())
+		}
+		return nil, nil, err
+	}
+
 	var (
 		num     = int(cfg.GetNum())
 		fnum    int

pkg/tools/cli/loadtest/service/search.go

@@ -34,6 +34,11 @@ func searchRequestProvider(dataset assets.Dataset) (func() any, int, error) {
 			}
 			ret = &payload.Search_Request{
 				Vector: v.([]float32),
+				Config: &payload.Search_Config{
+					Num:     10,
+					Radius:  -1,
+					Epsilon: 0.1,
+				},
 			}
 		}
 		return ret