Backport PR #2570 to main for 🔖 🤖 Release v1.7.13 #2571
Conversation
* 🔖 🤖 Release v1.7.13 Signed-off-by: Vdaas CI <[email protected]> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in a2061d1 according to the output from Gofumpt and Prettier. Details: #2570 --------- Signed-off-by: Vdaas CI <[email protected]> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Deploying vald with
|
| Latest commit: |
efa9763
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://caac74a0.vald.pages.dev |
| Branch Preview URL: | https://backport-main-prepare-releas.vald.pages.dev |
Walkthrough
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
[CHATOPS:HELP] ChatOps commands.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (53)
- CHANGELOG.md (1 hunks)
- charts/vald-benchmark-operator/Chart.yaml (1 hunks)
- charts/vald-benchmark-operator/README.md (3 hunks)
- charts/vald-benchmark-operator/values.yaml (2 hunks)
- charts/vald-helm-operator/Chart.yaml (1 hunks)
- charts/vald-helm-operator/README.md (3 hunks)
- charts/vald-helm-operator/values.yaml (1 hunks)
- charts/vald-readreplica/Chart.yaml (1 hunks)
- charts/vald-readreplica/README.md (1 hunks)
- charts/vald/Chart.yaml (1 hunks)
- charts/vald/README.md (2 hunks)
- charts/vald/values.yaml (1 hunks)
- k8s/agent/ngt/configmap.yaml (1 hunks)
- k8s/agent/pdb.yaml (1 hunks)
- k8s/agent/priorityclass.yaml (1 hunks)
- k8s/agent/statefulset.yaml (1 hunks)
- k8s/agent/svc.yaml (1 hunks)
- k8s/discoverer/clusterrole.yaml (1 hunks)
- k8s/discoverer/clusterrolebinding.yaml (1 hunks)
- k8s/discoverer/configmap.yaml (1 hunks)
- k8s/discoverer/deployment.yaml (2 hunks)
- k8s/discoverer/pdb.yaml (1 hunks)
- k8s/discoverer/priorityclass.yaml (1 hunks)
- k8s/discoverer/serviceaccount.yaml (1 hunks)
- k8s/discoverer/svc.yaml (1 hunks)
- k8s/gateway/gateway/ing.yaml (1 hunks)
- k8s/gateway/gateway/lb/configmap.yaml (1 hunks)
- k8s/gateway/gateway/lb/deployment.yaml (2 hunks)
- k8s/gateway/gateway/lb/hpa.yaml (1 hunks)
- k8s/gateway/gateway/lb/pdb.yaml (1 hunks)
- k8s/gateway/gateway/lb/priorityclass.yaml (1 hunks)
- k8s/gateway/gateway/lb/svc.yaml (1 hunks)
- k8s/index/job/correction/configmap.yaml (1 hunks)
- k8s/index/job/correction/cronjob.yaml (2 hunks)
- k8s/index/job/creation/configmap.yaml (1 hunks)
- k8s/index/job/creation/cronjob.yaml (2 hunks)
- k8s/index/job/save/configmap.yaml (1 hunks)
- k8s/index/job/save/cronjob.yaml (2 hunks)
- k8s/index/operator/configmap.yaml (1 hunks)
- k8s/index/operator/deployment.yaml (2 hunks)
- k8s/index/operator/priorityclass.yaml (1 hunks)
- k8s/manager/index/configmap.yaml (1 hunks)
- k8s/manager/index/deployment.yaml (2 hunks)
- k8s/manager/index/pdb.yaml (1 hunks)
- k8s/manager/index/priorityclass.yaml (1 hunks)
- k8s/manager/index/svc.yaml (1 hunks)
- k8s/operator/helm/operator.yaml (2 hunks)
- k8s/operator/helm/svc.yaml (1 hunks)
- k8s/readreplica/configmap.yaml (4 hunks)
- k8s/tools/benchmark/operator/configmap.yaml (2 hunks)
- k8s/tools/benchmark/operator/deployment.yaml (2 hunks)
- k8s/tools/benchmark/operator/service.yaml (1 hunks)
- versions/VALD_VERSION (1 hunks)
Files skipped from review due to trivial changes (46)
- charts/vald-benchmark-operator/Chart.yaml
- charts/vald-benchmark-operator/README.md
- charts/vald-benchmark-operator/values.yaml
- charts/vald-helm-operator/Chart.yaml
- charts/vald-helm-operator/values.yaml
- charts/vald-readreplica/Chart.yaml
- charts/vald-readreplica/README.md
- charts/vald/Chart.yaml
- charts/vald/README.md
- charts/vald/values.yaml
- k8s/agent/ngt/configmap.yaml
- k8s/agent/pdb.yaml
- k8s/agent/priorityclass.yaml
- k8s/agent/statefulset.yaml
- k8s/agent/svc.yaml
- k8s/discoverer/clusterrole.yaml
- k8s/discoverer/clusterrolebinding.yaml
- k8s/discoverer/configmap.yaml
- k8s/discoverer/deployment.yaml
- k8s/discoverer/pdb.yaml
- k8s/discoverer/priorityclass.yaml
- k8s/discoverer/serviceaccount.yaml
- k8s/discoverer/svc.yaml
- k8s/gateway/gateway/ing.yaml
- k8s/gateway/gateway/lb/configmap.yaml
- k8s/gateway/gateway/lb/hpa.yaml
- k8s/gateway/gateway/lb/pdb.yaml
- k8s/gateway/gateway/lb/priorityclass.yaml
- k8s/gateway/gateway/lb/svc.yaml
- k8s/index/job/correction/configmap.yaml
- k8s/index/job/correction/cronjob.yaml
- k8s/index/job/creation/configmap.yaml
- k8s/index/job/creation/cronjob.yaml
- k8s/index/job/save/configmap.yaml
- k8s/index/job/save/cronjob.yaml
- k8s/index/operator/configmap.yaml
- k8s/index/operator/priorityclass.yaml
- k8s/manager/index/configmap.yaml
- k8s/manager/index/pdb.yaml
- k8s/manager/index/priorityclass.yaml
- k8s/manager/index/svc.yaml
- k8s/operator/helm/svc.yaml
- k8s/tools/benchmark/operator/configmap.yaml
- k8s/tools/benchmark/operator/deployment.yaml
- k8s/tools/benchmark/operator/service.yaml
- versions/VALD_VERSION
Additional context used
Markdownlint
charts/vald-helm-operator/README.md
29-29: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
30-30: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
35-35: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
Additional comments not posted (37)
k8s/operator/helm/operator.yaml (3)
24-24: Update Helm chart version to v1.7.13The
helm.sh/chartlabel has been correctly updated tovald-helm-operator-v1.7.13.
27-27: Update application version to v1.7.13The
app.kubernetes.io/versionlabel has been correctly updated tov1.7.13.
45-45: Update container image tag to v1.7.13The container image tag has been correctly updated to
vdaas/vald-helm-operator:v1.7.13.k8s/index/operator/deployment.yaml (3)
23-23: Update Helm chart version to v1.7.13The
helm.sh/chartlabel has been correctly updated tovald-v1.7.13.
26-26: Update application version to v1.7.13The
app.kubernetes.io/versionlabel has been correctly updated tov1.7.13.
49-49: Update checksum value for configmapThe
checksum/configmapannotation has been correctly updated to reflect the new configuration data.k8s/manager/index/deployment.yaml (3)
23-23: Update Helm chart version to v1.7.13The
helm.sh/chartlabel has been correctly updated tovald-v1.7.13.
26-26: Update application version to v1.7.13The
app.kubernetes.io/versionlabel has been correctly updated tov1.7.13.
49-49: Update checksum value for configmapThe
checksum/configmapannotation has been correctly updated to reflect the new configuration data.k8s/readreplica/configmap.yaml (5)
22-22: Version update in metadata section approved.The version update from
v1.7.12tov1.7.13is consistent and correct.
25-25: Version update in metadata section approved.The version update from
v1.7.12tov1.7.13is consistent and correct.
93-93: Restart field addition approved.The
restartfield addition with a value oftrueis intentional and correct.Ensure that this change aligns with the intended restart behavior of the service.
Verification successful
Restart field addition approved.
The
restartfield addition with a value oftrueis intentional and correct. It appears consistently across multiple configuration files, indicating a standardized approach.
- Ensure that this change aligns with the intended restart behavior of the service.
- Verify the context and usage of the
restartfield to confirm it is correctly implemented and intended.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the restart field in the codebase. # Test: Search for the restart field usage. Expect: Only occurrences of the new restart value. rg --type yaml -A 5 $'restart:'Length of output: 128564
195-195: Enable_statistics field change approved.The
enable_statisticsfield change fromtruetofalseis intentional and correct.Ensure that this change aligns with the intended behavior regarding statistics collection.
90-90: Mode change approved.The
modefield change from an empty string toRESTis intentional and correct.Ensure that this change aligns with the intended operational mode of the service.
Verification successful
Mode change approved.
The
modefield change from an empty string toRESTis intentional and correct. This aligns with other configurations in the codebase whereRESTis used as a mode.
- k8s/readreplica/configmap.yaml:
mode: RESTEnsure that this change aligns with the intended operational mode of the service.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the mode field in the codebase. # Test: Search for the mode field usage. Expect: Only occurrences of the new mode value. rg --type yaml -A 5 $'mode:'Length of output: 156289
k8s/gateway/gateway/lb/deployment.yaml (3)
23-23: Version update in metadata section approved.The version update from
v1.7.12tov1.7.13is consistent and correct.
26-26: Version update in metadata section approved.The version update from
v1.7.12tov1.7.13is consistent and correct.
48-48: Checksum update approved.The checksum update for the configuration map is consistent and correct.
charts/vald-helm-operator/README.md (5)
5-5: Version update in documentation approved.The version update from
v1.7.12tov1.7.13is consistent and correct.
29-29: CRD URL update in documentation approved.The CRD URL update to reflect the new version
v1.7.13is consistent and correct.Tools
Markdownlint
29-29: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
30-30: CRD URL update in documentation approved.The CRD URL update to reflect the new version
v1.7.13is consistent and correct.Tools
Markdownlint
30-30: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
35-35: Patch command update in documentation approved.The patch command update to reflect the new version
v1.7.13is consistent and correct.Tools
Markdownlint
35-35: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
82-82: Image tag update in documentation approved.The image tag update to reflect the new version
v1.7.13is consistent and correct.CHANGELOG.md (15)
3-3: LGTM!The section header for version 1.7.13 is correctly formatted.
5-56: LGTM!The Docker images section is well-structured and provides clear Docker pull commands for each component.
58-63: LGTM!The Documents section is well-structured and provides useful links to documentation.
64-64: LGTM!The section header for Changes is correctly formatted.
66-79: LGTM!The Bugfix section is well-structured and provides detailed information on the bug fixes.
80-84: LGTM!The Backport and Release-Related section is well-structured and provides detailed information on the changes.
85-89: LGTM!The E2E and Index section is well-structured and provides detailed information on the changes.
90-93: LGTM!The Documentation and Other section is well-structured and provides detailed information on the changes.
94-107: LGTM!The Enhancement section is well-structured and provides detailed information on the enhancements.
109-113: LGTM!The Performance and Optimization section is well-structured and provides detailed information on the changes.
114-117: LGTM!The Testing and Metrics section is well-structured and provides detailed information on the changes.
118-125: LGTM!The CI section is well-structured and provides detailed information on the changes.
126-131: LGTM!The Backport section is well-structured and provides detailed information on the changes.
132-139: LGTM!The Documentation section is well-structured and provides detailed information on the changes.
140-149: LGTM!The Other section is well-structured and provides detailed information on the changes.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (53)
- CHANGELOG.md (1 hunks)
- charts/vald-benchmark-operator/Chart.yaml (1 hunks)
- charts/vald-benchmark-operator/README.md (3 hunks)
- charts/vald-benchmark-operator/values.yaml (2 hunks)
- charts/vald-helm-operator/Chart.yaml (1 hunks)
- charts/vald-helm-operator/README.md (3 hunks)
- charts/vald-helm-operator/values.yaml (1 hunks)
- charts/vald-readreplica/Chart.yaml (1 hunks)
- charts/vald-readreplica/README.md (1 hunks)
- charts/vald/Chart.yaml (1 hunks)
- charts/vald/README.md (2 hunks)
- charts/vald/values.yaml (1 hunks)
- k8s/agent/ngt/configmap.yaml (1 hunks)
- k8s/agent/pdb.yaml (1 hunks)
- k8s/agent/priorityclass.yaml (1 hunks)
- k8s/agent/statefulset.yaml (1 hunks)
- k8s/agent/svc.yaml (1 hunks)
- k8s/discoverer/clusterrole.yaml (1 hunks)
- k8s/discoverer/clusterrolebinding.yaml (1 hunks)
- k8s/discoverer/configmap.yaml (1 hunks)
- k8s/discoverer/deployment.yaml (2 hunks)
- k8s/discoverer/pdb.yaml (1 hunks)
- k8s/discoverer/priorityclass.yaml (1 hunks)
- k8s/discoverer/serviceaccount.yaml (1 hunks)
- k8s/discoverer/svc.yaml (1 hunks)
- k8s/gateway/gateway/ing.yaml (1 hunks)
- k8s/gateway/gateway/lb/configmap.yaml (1 hunks)
- k8s/gateway/gateway/lb/deployment.yaml (2 hunks)
- k8s/gateway/gateway/lb/hpa.yaml (1 hunks)
- k8s/gateway/gateway/lb/pdb.yaml (1 hunks)
- k8s/gateway/gateway/lb/priorityclass.yaml (1 hunks)
- k8s/gateway/gateway/lb/svc.yaml (1 hunks)
- k8s/index/job/correction/configmap.yaml (1 hunks)
- k8s/index/job/correction/cronjob.yaml (2 hunks)
- k8s/index/job/creation/configmap.yaml (1 hunks)
- k8s/index/job/creation/cronjob.yaml (2 hunks)
- k8s/index/job/save/configmap.yaml (1 hunks)
- k8s/index/job/save/cronjob.yaml (2 hunks)
- k8s/index/operator/configmap.yaml (1 hunks)
- k8s/index/operator/deployment.yaml (2 hunks)
- k8s/index/operator/priorityclass.yaml (1 hunks)
- k8s/manager/index/configmap.yaml (1 hunks)
- k8s/manager/index/deployment.yaml (2 hunks)
- k8s/manager/index/pdb.yaml (1 hunks)
- k8s/manager/index/priorityclass.yaml (1 hunks)
- k8s/manager/index/svc.yaml (1 hunks)
- k8s/operator/helm/operator.yaml (2 hunks)
- k8s/operator/helm/svc.yaml (1 hunks)
- k8s/readreplica/configmap.yaml (4 hunks)
- k8s/tools/benchmark/operator/configmap.yaml (2 hunks)
- k8s/tools/benchmark/operator/deployment.yaml (2 hunks)
- k8s/tools/benchmark/operator/service.yaml (1 hunks)
- versions/VALD_VERSION (1 hunks)
Files skipped from review due to trivial changes (48)
- charts/vald-benchmark-operator/Chart.yaml
- charts/vald-benchmark-operator/README.md
- charts/vald-benchmark-operator/values.yaml
- charts/vald-helm-operator/Chart.yaml
- charts/vald-helm-operator/values.yaml
- charts/vald-readreplica/Chart.yaml
- charts/vald-readreplica/README.md
- charts/vald/Chart.yaml
- charts/vald/README.md
- charts/vald/values.yaml
- k8s/agent/ngt/configmap.yaml
- k8s/agent/pdb.yaml
- k8s/agent/priorityclass.yaml
- k8s/agent/statefulset.yaml
- k8s/agent/svc.yaml
- k8s/discoverer/clusterrole.yaml
- k8s/discoverer/clusterrolebinding.yaml
- k8s/discoverer/configmap.yaml
- k8s/discoverer/deployment.yaml
- k8s/discoverer/pdb.yaml
- k8s/discoverer/priorityclass.yaml
- k8s/discoverer/serviceaccount.yaml
- k8s/discoverer/svc.yaml
- k8s/gateway/gateway/ing.yaml
- k8s/gateway/gateway/lb/configmap.yaml
- k8s/gateway/gateway/lb/hpa.yaml
- k8s/gateway/gateway/lb/pdb.yaml
- k8s/gateway/gateway/lb/priorityclass.yaml
- k8s/gateway/gateway/lb/svc.yaml
- k8s/index/job/correction/configmap.yaml
- k8s/index/job/correction/cronjob.yaml
- k8s/index/job/creation/configmap.yaml
- k8s/index/job/creation/cronjob.yaml
- k8s/index/job/save/configmap.yaml
- k8s/index/job/save/cronjob.yaml
- k8s/index/operator/configmap.yaml
- k8s/index/operator/deployment.yaml
- k8s/index/operator/priorityclass.yaml
- k8s/manager/index/configmap.yaml
- k8s/manager/index/pdb.yaml
- k8s/manager/index/priorityclass.yaml
- k8s/manager/index/svc.yaml
- k8s/operator/helm/operator.yaml
- k8s/operator/helm/svc.yaml
- k8s/tools/benchmark/operator/configmap.yaml
- k8s/tools/benchmark/operator/deployment.yaml
- k8s/tools/benchmark/operator/service.yaml
- versions/VALD_VERSION
Additional context used
Markdownlint
charts/vald-helm-operator/README.md
29-29: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
30-30: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
35-35: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
Additional comments not posted (25)
k8s/manager/index/deployment.yaml (3)
23-23: Version update for Helm chart label.The
helm.sh/chartlabel has been correctly updated fromvald-v1.7.12tovald-v1.7.13.
26-26: Version update for application version label.The
app.kubernetes.io/versionlabel has been correctly updated fromv1.7.12tov1.7.13.
49-49: Checksum update for configmap.The
checksum/configmapannotation has been updated, indicating a change in the configuration data.k8s/readreplica/configmap.yaml (5)
22-22: Version update for Helm chart label.The
helm.sh/chartlabel has been correctly updated fromvald-readreplica-v1.7.12tovald-readreplica-v1.7.13.
25-25: Version update for application version label.The
app.kubernetes.io/versionlabel has been correctly updated fromv1.7.12tov1.7.13.
90-90: Mode parameter update.The
modeparameter has been updated from an empty string toREST, indicating a shift in operational mode.Ensure that this change is consistent with the intended operational mode.
93-93: Restart parameter update.The
restartparameter has been introduced and set totrue, likely enabling automatic restarts of the agent.Also applies to: 118-118
195-195: Enable statistics parameter update.The
enable_statisticsparameter has been added and set tofalse, likely controlling the collection of statistical data.k8s/gateway/gateway/lb/deployment.yaml (3)
23-23: Version update for Helm chart label.The
helm.sh/chartlabel has been correctly updated fromvald-v1.7.12tovald-v1.7.13.
26-26: Version update for application version label.The
app.kubernetes.io/versionlabel has been correctly updated fromv1.7.12tov1.7.13.
48-48: Checksum update for configmap.The
checksum/configmapannotation has been updated, indicating a change in the configuration data.charts/vald-helm-operator/README.md (5)
5-5: Version update approved.The version update from
v1.7.12tov1.7.13is correct and consistent with the PR summary.
29-29: URL update for CRDs approved.The URL update to use
v1.7.13for replacing CRDs is correct and consistent with the new version.Tools
Markdownlint
29-29: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
30-30: URL update for CRDs approved.The URL update to use
v1.7.13for replacing CRDs is correct and consistent with the new version.Tools
Markdownlint
30-30: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
35-35: Command update forvhorresource approved.The command update to use
v1.7.13for patching thevhorresource is correct and consistent with the new version.Tools
Markdownlint
35-35: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
82-82: Image tag update approved.The image tag update to
v1.7.13in the configuration table is correct and consistent with the new version.CHANGELOG.md (9)
5-55: LGTM! Docker image pull commands are correct and well-formatted.The Docker image pull commands for various components are accurate and consistently formatted.
58-62: LGTM! Document links are correct and well-formatted.The links to GoDoc, Helm Chart Reference, and Helm Operator Chart Reference are accurate and consistently formatted.
66-93: LGTM! Bugfixes are correctly described and well-formatted.The bug fixes are accurately described, and all links are correct and consistently formatted.
94-117: LGTM! Enhancements are correctly described and well-formatted.The enhancements are accurately described, and all links are correct and consistently formatted.
118-124: LGTM! CI changes are correctly described and well-formatted.The CI changes are accurately described, and all links are correct and consistently formatted.
126-131: LGTM! Backported changes are correctly described and well-formatted.The backported changes are accurately described, and all links are correct and consistently formatted.
132-138: LGTM! Documentation updates are correctly described and well-formatted.The documentation updates are accurately described, and all links are correct and consistently formatted.
140-149: LGTM! Other changes are correctly described and well-formatted.The other changes are accurately described, and all links are correct and consistently formatted.
3-3: LGTM! Section for v1.7.12 is correctly formatted.The section for v1.7.12 is correctly formatted and consistent with the rest of the document.
Release PR for v1.7.13.