Skip to content

Commit

Permalink
Keep PipelineResource.status field for backward compatibility 👾
Browse files Browse the repository at this point in the history
They are not used, and shouldn't be there, but client that have
previous version of this struct would fail targeting the API.

This is a *partial* revert of tektoncd#1640, as it doesn't reintroduce the
`UpdateStatus` generation.

Signed-off-by: Vincent Demeester <[email protected]>
  • Loading branch information
vdemeester committed Dec 19, 2019
1 parent de5493e commit 5bb50ee
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 0 deletions.
12 changes: 12 additions & 0 deletions pkg/apis/pipeline/v1alpha1/resource_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,18 @@ type PipelineResource struct {

// Spec holds the desired state of the PipelineResource from the client
Spec PipelineResourceSpec `json:"spec,omitempty"`

// Status is deprecated.
// It usually is used to communicate the observed state of the PipelineResource from
// the controller, but was unused as there is no controller for PipelineResource.
// +optional
Status *PipelineResourceStatus `json:"status,omitempty"`
}

// PipelineResourceStatus does not contain anything because PipelineResources on their own
// do not have a status
// Deprecated
type PipelineResourceStatus struct {
}

// PipelineResourceBinding connects a reference to an instance of a PipelineResource
Expand Down
21 changes: 21 additions & 0 deletions pkg/apis/pipeline/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 5bb50ee

Please sign in to comment.