Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement smarter scrolling behavior in VuiChat. #112

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Implement smarter scrolling behavior in VuiChat. #112

merged 2 commits into from
Aug 31, 2023

Conversation

cjcenizal
Copy link
Contributor

No description provided.

@cjcenizal cjcenizal added the enhancement New feature or request label Aug 31, 2023
@cjcenizal cjcenizal requested a review from 3eif August 31, 2023 15:34
3eif
3eif reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@3eif 3eif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be testing this incorrectly but the chat box is not scrolling down if you're already at the bottom. It also doesn't scroll down if you scroll up to a random position then scroll all the way back down.

Screen.Recording.2023-08-31.at.9.34.08.AM.mov

@cjcenizal
Copy link
Contributor Author

@3eif Good catch! I think I've got it fixed now. Can you take another look?

3eif
3eif approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@3eif 3eif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM

@cjcenizal cjcenizal merged commit b7dcfb7 into main Aug 31, 2023
@cjcenizal cjcenizal deleted the feature/chat-scroll branch August 31, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3eif 3eif 3eif approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjcenizal @3eif