-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring leaving space experience in line with Web #4850
Comments
- [Space home view inherits title from previously viewed tab](#4851) - [Home view doesn't refresh when new rooms are created](#4849) - [Odd error message in Space member list](#4845) - [Bring leaving space experience in line with Web](#4850) - [No notification for space invitation](#4840) - [Remove filter when space is switched](#4852) - [M10.11 Remove community tab](#4493)
@gileluard Just recently (in the last day or so) improved the copy of the leave Spaces so this is a bit out of date. I can take a look and suggest new copy here |
Removing release blocker label as it's no longer a blocker in its current state |
@nadonomy @kittykat here is the actual screen on web: As you can see, the list of rooms is not displayed if the user doesn't select first We could base the UI on the list of rooms so the user can see the rooms that belongs to this space. Having |
@gileluard that's a much nicer interaction IMO than having the three options and then choosing later. Some notes:
|
@gileluard +1 to Kats comments. There's also some other visual & interaction tweaks we should make, things like:
Etc. @gileluard can you remind me of the timeliness/which RC you want to merge this in for? Wondering how to action. |
If we could have this implemented and tested by 4th April, that would be ideal 👍 |
@kittykat @gileluard great! @amshakal is taking a look at this now, also benchmarking Android to consider cross-platform consistency here on mobile. |
@amshakal I'm almost done with this feature. Let me know if there is something I should change Also I'm wondering if we shouldn't rather display an simple alert if the space is empty as we display a large empty view in this case: |
After discussing with @kittykat @fedrunov @gileluard, I've got some alternative designs that aim to:
These designs aren't comprehensive, just trying to address the largest concerns that came from the meeting - any thoughts welcome and if we have a preferred route, I'll make more comprehensive designs and of course the android equivalent. Idea 1 As little change as possible
ele-ios-leave-space-1.movIdea 2 Split the steps
ele-ios-leave-space-3.movIdea 3 Remove select none
ele-ios-leave-space-2.mov |
Thanks @niquewoodhouse
|
- Hide selection bar when filtering room list
* Bring leaving space experience in line with Web #4850 - Done
Your use case
Current behaviour on iOS: when a user leaves a space, they do not leave the rooms in that space
User should be able to leave a space without having to leave many rooms individually after the fact. Behaviour should be brought into line with web to offer three options.
Have you considered any alternatives?
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: