Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Mark as read" #6278

Closed
gileluard opened this issue Jun 13, 2022 · 3 comments · Fixed by #6346
Closed

Add "Mark as read" #6278

gileluard opened this issue Jun 13, 2022 · 3 comments · Fixed by #6346
Assignees
Labels
A-Timeline T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Team: Delight X-Needs-Design May require input from the design team Z-WTF WTF issues: High impact, Low Effort

Comments

@gileluard
Copy link
Contributor

gileluard commented Jun 13, 2022

Your use case

What would you like to do?

As proposed by some users, it could be nice to mark individually a room as read especially now we have a room preview from the Home Screen.

Why would you like to do it?

The "mark as read" feature is already implemented in the SDK and it may be worth thinking about using it for a single room instead of having this option for all rooms in the settings.

How would you like to achieve it?

At first we could add an option in the room context menu but we may have other way to access this feature:
Simulator Screen Shot - iPhone 12 Pro - 2022-06-13 at 14 49 25

Have you considered any alternatives?

I let @amshakal thinks if this feature is viable and the right way to have a clear UX.

Additional context

No response

@gileluard gileluard added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jun 13, 2022
@daniellekirkwood
Copy link
Contributor

There were 2 product questions raised:
Can it go out one platform and not all & does it matter that we have it only in one direction

  • Mark as read is also offered on Android (in some capacity) so yes, we should launch this on iOS also and create the issues needed to apply this cross-platform.
  • It does not matter that we have 'Mark as Read' and not 'Mark as Unread' - ideally we would have both but as that's not currently possible it's ok without.

For both cases we should "err" towards shipping!

Let's go, thanks @gileluard! 🚀

@daniellekirkwood daniellekirkwood removed their assignment Jun 14, 2022
@daniellekirkwood daniellekirkwood added X-Needs-Design May require input from the design team Z-WTF WTF issues: High impact, Low Effort A-Timeline Team: Delight labels Jun 14, 2022
@aaronraimist
Copy link
Contributor

element-hq/element-web#13859 is the Web issue for this

@amshakal
Copy link

amshakal commented Jun 27, 2022

If we are okay with the product considerations raised above, interaction/design wise this solution seems fine to me. Thanks Gil! I imagine we will add this to People and Rooms both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Team: Delight X-Needs-Design May require input from the design team Z-WTF WTF issues: High impact, Low Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants