Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check enabled field in notification settings push toggles #6814

Closed
gileluard opened this issue Oct 6, 2022 · 0 comments · Fixed by #6815
Closed

Check enabled field in notification settings push toggles #6814

gileluard opened this issue Oct 6, 2022 · 0 comments · Fixed by #6815
Assignees
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@gileluard
Copy link
Contributor

Your use case

Currently, this toggle is enabled when the device has a registered pusher. Disabling the toggle removes the pusher. Enabling the toggle registers a pusher.

AC

  • the ‘notifications on this device’ toggle should check the pusher.enabled field and display as off when pusher.enabled is false
  • When the enabled field is missing/MSC3381 not supported - the pusher should be considered enabled
  • When there is a registered pusher with enabled: false - toggling on should set the enabled field to true on the existing pusher
  • When there is not registered pusher, the toggle should be displayed as off - toggling on should create a new pusher (current behaviour)
    • new pushers will default to enabled: true on servers that support the field so it’s fine to omit enabledwhen creating the pusher
  • Disabling the toggle should remove the pusher (current behaviour)
    -whether enabled is supported or not, the pusher should always be removed instead of disabled

Have you considered any alternatives?

No response

Additional context

No response

@gileluard gileluard added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Oct 6, 2022
@gileluard gileluard self-assigned this Oct 6, 2022
@gileluard gileluard changed the title Check enabled field in notification settings push toggles – iOS Check enabled field in notification settings push toggles Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant