Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rich Text Editor: Fullscreen dragging dismissal doesn't always work when there is a lot of text #7116

Closed
Velin92 opened this issue Nov 29, 2022 · 0 comments · Fixed by #7117
Closed

Rich Text Editor: Fullscreen dragging dismissal doesn't always work when there is a lot of text #7116

Velin92 opened this issue Nov 29, 2022 · 0 comments · Fixed by #7117
Labels
A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Labs

Comments

@Velin92
Copy link
Member

Velin92 commented Nov 29, 2022

Steps to reproduce

Type a lot of text in the rich text composer with a lot of newlines
Type until the text reaches the maximum non fullscreen height
Then tap the fullscreen button
Then try to dismiss the view by dragging all the way to the bottom

Outcome

What did you expect?

The view should dismiss as soon as the drag is released

What happened instead?

It doesn't always dismissa

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@Velin92 Velin92 added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor labels Nov 29, 2022
@Velin92 Velin92 linked a pull request Nov 29, 2022 that will close this issue
Fix Rich text Editor Fullscreen dragging through dismiss #7117
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Rich text Editor Fullscreen dragging through dismiss element-hq/element-ios
1 participant
@Velin92