Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOSDEM implementation inconsistencies #565

Closed
callumu opened this issue Feb 10, 2023 · 1 comment · Fixed by #573
Closed

FOSDEM implementation inconsistencies #565

callumu opened this issue Feb 10, 2023 · 1 comment · Fixed by #573
Assignees
Labels
Z-BBQ-Beta Required for ElementX - BBQ - Beta

Comments

@callumu
Copy link

callumu commented Feb 10, 2023

  1. Background colour - for full screen pages the background colour should be the lightest colour (Compound/Light/Background) and the opposite in dark mode. For modals, the background colour should be the next lightest colour (Compound/Light/System Light) and the opposite in dark mode. Currently there are inconsistencies on the settings and room settings pages across both themes - I’ve updated our new file to match this so you can use it as the source of truth.
 This background colour should be the same across all pages and modals of the app - is it possible to set this as a rule instead of individually adjusting them?

Settings: https://www.figma.com/file/0MMNu7cTOzLOlWb7ctTkv3/Element-X-\(new\)?node-id=5%3A7387

Room settings: https://www.figma.com/file/0MMNu7cTOzLOlWb7ctTkv3/Element-X-\(new\)?node-id=5%3A7388

Room list header - this should have the same opacity as the All Chats header if possible?

[Room settings page](https://www.figma.com/file/0MMNu7cTOzLOlWb7ctTkv3/Element-X-(new)?node-id=5%3A7388\) - we are missing the Matrix ID and Topic from the implementation. I think Gil worked to add these, so I’m not sure why they’re not in there. Could you add them? There are also some changes needed for text weight and size of the ‘Topic’, ‘About’ and ‘Security’ headers. Again, the file is accurate and the source of truth for these.

@pixlwave pixlwave added the Z-BBQ-Beta Required for ElementX - BBQ - Beta label Feb 10, 2023
@pixlwave
Copy link
Member

pixlwave commented Feb 13, 2023

  1. Is closed by Tweak the design of various Forms to match Figma #573.
  2. Separate issue Fix translucency of RoomScreen navigation bar. #574.
  3. Headers fixed, missing topic/alias are because we don't have the data. Fixed by Add required state on subscribe. #589.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-BBQ-Beta Required for ElementX - BBQ - Beta
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants