Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten room list #121

Merged
merged 4 commits into from
Jun 30, 2022
Merged

Flatten room list #121

merged 4 commits into from
Jun 30, 2022

Conversation

ismailgulek
Copy link
Contributor

@ismailgulek ismailgulek commented Jun 29, 2022

Flattens the room list by removing encrypted groups. Also styles the screen a bit.

Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-30 at 02 32 20

ismailgulek added a commit that referenced this pull request Jun 29, 2022
@ismailgulek ismailgulek force-pushed the ismail/flat_room_list branch from f88a180 to c9906f3 Compare June 29, 2022 22:02
@ismailgulek ismailgulek requested review from a team and stefanceriu and removed request for a team June 29, 2022 22:03
@github-actions
Copy link

github-actions bot commented Jun 29, 2022

Changes in 121 (2022-06-30)

✨ Features

  • Implement rageshake service. (#23)
  • Add filtering for rooms by name. (#26)
  • Settings screen minimal implementation. (#37)
  • DesignKit: Add initial implementation of DesignKit to the repo as a Swift package. (#43)
  • Room timeline: Add plain styler and add timeline option in settings screen. (#92)
  • Implement and use background tasks. (#99)

🙌 Improvements

  • Implement new ClientBuilder pattern for login (#120)
  • Flatten the room list by removing the encrypted groups. (#121)
  • Room: Use bubbles in the timeline. (#34)
  • Room: Add header view containing room avatar and encryption badge. (#35)
  • Add a the splash screen and login screen from Element iOS along with a UserSessionStore. (#40)
  • DesignKit: Add DesignKit to the ElementX project, style the login screen with it and tint the whole app. (#43)
  • Settings: Auto dismiss bug report screen and show a success indicator when bug report completed. (#76)
  • Bug report: Add GH labels. (#77)
  • Danger: Add a check for png files and warn to use SVG and PDF files. (#87)
  • Add localizations to UI tests target and add some checks. (#101)

🐛 Bugfixes

  • ElementInfoPlist: Use custom template for Info.plist. (#71)

🧱 Build

  • Use v0.0.1 of the DesignTokens package. (#78)
  • Update to v0.0.2 of the DesignTokens package. (#90)
  • Fix Danger's changelog detection. (#74)

Others

  • Fix project urls in Towncrier configuration. (#96)

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/9GeNmc

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022

Codecov Report

Merging #121 (a9eb68f) into develop (7bd4763) will increase coverage by 0.05%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #121      +/-   ##
===========================================
+ Coverage    27.12%   27.17%   +0.05%     
===========================================
  Files          148      148              
  Lines        10578    10557      -21     
  Branches      5188     5172      -16     
===========================================
  Hits          2869     2869              
+ Misses        7626     7605      -21     
  Partials        83       83              
Impacted Files Coverage Δ
.../Sources/Screens/HomeScreen/HomeScreenModels.swift 9.09% <0.00%> (+1.94%) ⬆️
...X/Sources/Screens/HomeScreen/View/HomeScreen.swift 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bd4763...a9eb68f. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ismailgulek ismailgulek requested a review from pixlwave June 30, 2022 08:53
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👏

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you need my full review too, but if you do... ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants