Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DesignKit package #57

Merged
merged 3 commits into from
May 26, 2022
Merged

Add DesignKit package #57

merged 3 commits into from
May 26, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented May 13, 2022

Adds a Swift package containing the start of the DesignKit project. This references dynamic colours that are generated from an Amazon Style dictionary in https://github.com/vector-im/element-design-tokens along with fonts that are copied from Element iOS. One day the fonts should hopefully be generated by the style dictionary, at which point DesignKit can become a components only package.

Another PR will follow this one that adds the package ready for use in the project.

@github-actions
Copy link

github-actions bot commented May 13, 2022

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Please add a changelog.

Generated by 🚫 Danger Swift against 02f9a54

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #57 (bdad31c) into develop (b4d9c72) will not change coverage.
The diff coverage is n/a.

❗ Current head bdad31c differs from pull request most recent head 02f9a54. Consider uploading reports for the commit 02f9a54 to get more accurate results

@@           Coverage Diff           @@
##           develop     #57   +/-   ##
=======================================
  Coverage     8.25%   8.25%           
=======================================
  Files           96      96           
  Lines         7833    7833           
  Branches      4174    4174           
=======================================
  Hits           647     647           
  Misses        7176    7176           
  Partials        10      10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d9c72...02f9a54. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 13, 2022

Changes in 57 (2022-05-26)

✨ Features

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Bq8iXW

@pixlwave pixlwave force-pushed the doug/designkit branch 4 times, most recently from 4cf0652 to 4aa03f5 Compare May 20, 2022 15:44
@pixlwave pixlwave force-pushed the doug/designkit branch 2 times, most recently from 3d17d23 to bdad31c Compare May 24, 2022 09:35
@pixlwave pixlwave marked this pull request as ready for review May 24, 2022 09:36
@stefanceriu stefanceriu requested review from a team and stefanceriu and removed request for a team May 24, 2022 09:47
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from previews not working in the package itself (which we talked about and decided to ignore for now) this looks amazing! I can't wait to start using it. 👏

Package.swift Show resolved Hide resolved
DesignKit/Sources/Fonts/ElementFonts.swift Outdated Show resolved Hide resolved
DesignKit/Sources/Fonts/ElementUIFonts.swift Outdated Show resolved Hide resolved
Make fonts let instead of var.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants