-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DesignKit package #57
Conversation
Generated by 🚫 Danger Swift against 02f9a54 |
Codecov Report
@@ Coverage Diff @@
## develop #57 +/- ##
=======================================
Coverage 8.25% 8.25%
=======================================
Files 96 96
Lines 7833 7833
Branches 4174 4174
=======================================
Hits 647 647
Misses 7176 7176
Partials 10 10 Continue to review full report at Codecov.
|
Changes in 57 (2022-05-26)✨ Features 📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Bq8iXW |
4cf0652
to
4aa03f5
Compare
Remove vc_ and unnecessary selfs.
3d17d23
to
bdad31c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from previews not working in the package itself (which we talked about and decided to ignore for now) this looks amazing! I can't wait to start using it. 👏
Make fonts let instead of var.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Adds a Swift package containing the start of the DesignKit project. This references dynamic colours that are generated from an Amazon Style dictionary in https://github.com/vector-im/element-design-tokens along with fonts that are copied from Element iOS. One day the fonts should hopefully be generated by the style dictionary, at which point DesignKit can become a components only package.
Another PR will follow this one that adds the package ready for use in the project.