Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VRL conditions should be type-checked at compile-time #17175

Closed
fuchsnj opened this issue Apr 19, 2023 · 0 comments · Fixed by #17894
Closed

VRL conditions should be type-checked at compile-time #17175

fuchsnj opened this issue Apr 19, 2023 · 0 comments · Fixed by #17894
Assignees
@pront
Labels
domain: vrl Anything related to the Vector Remap Language type: feature A value-adding code addition that introduce new functionality.

Comments

@fuchsnj
Copy link
Member

fuchsnj commented Apr 19, 2023 •
edited
Loading

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

Right now when VRL conditions are used (for example in a filter transform), the VRL program must return a boolean. VRL is capable of knowing the resulting type of a program, but this is only checked at runtime. This should be checked at compile time to ensure the VRL condition is valid.
@fuchsnj fuchsnj added type: feature A value-adding code addition that introduce new functionality. domain: vrl Anything related to the Vector Remap Language labels Apr 19, 2023
@jszwedko jszwedko changed the title VRL conditions should be type-checked at runtime VRL conditions should be type-checked at compile-time Jun 12, 2023
@pront pront self-assigned this Jul 6, 2023
@pront pront mentioned this issue Jul 6, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 6, 2023
@pront
enhancement: check VRL conditions return type at compile time (#17894)
fa489f8 
closes: #17175 

As discussed offline with @fuchsnj, we do not need to handle fallible
conditions because providing a fallible condition already results in an
error.
@pront pront mentioned this issue Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pront pront

Labels
domain: vrl Anything related to the Vector Remap Language type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhancement: check VRL conditions return type at compile time vectordotdev/vector
2 participants
@pront @fuchsnj