Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws_ec2_metadata transform): Test compliance to instrumentation spec in aws_ec2_metadata transform #14120

Merged

Conversation

pablosichert
Copy link
Contributor

Part of #14063.

@netlify
Copy link

netlify bot commented Aug 26, 2022

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit 22bb7ef
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/63207e453b474800087d1df0
😎 Deploy Preview https://deploy-preview-14120--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the domain: transforms Anything related to Vector's transform components label Aug 26, 2022
@github-actions
Copy link

Soak Test Results

Baseline: deea758
Comparison: 80cda00
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
http_text_to_http_json 248.8KiB 0.6 100.00% 40.35MiB 758.48KiB 15.48KiB 0 0.0183514 40.6MiB 686.01KiB 14.0KiB 0 0.0164986 False False
datadog_agent_remap_blackhole 288.04KiB 0.46 99.07% 61.69MiB 4.48MiB 93.25KiB 0 0.0725525 61.97MiB 2.85MiB 59.6KiB 0 0.046045 False False
datadog_agent_remap_blackhole_acks 172.65KiB 0.28 79.14% 60.65MiB 5.26MiB 109.45KiB 0 0.0866588 60.82MiB 3.96MiB 82.87KiB 0 0.0651297 False False
socket_to_socket_blackhole 49.28KiB 0.2 100.00% 23.59MiB 113.35KiB 2.31KiB 0 0.00469106 23.64MiB 110.12KiB 2.25KiB 0 0.00454804 False False
syslog_regex_logs2metric_ddmetrics 17.71KiB 0.14 71.39% 12.44MiB 581.32KiB 11.84KiB 0 0.0456077 12.46MiB 570.92KiB 11.63KiB 0 0.0447294 False False
syslog_humio_logs 13.21KiB 0.08 99.75% 16.52MiB 157.48KiB 3.21KiB 0 0.00930699 16.53MiB 143.93KiB 2.94KiB 0 0.00849972 False False
splunk_hec_to_splunk_hec_logs_noack 16.8KiB 0.07 84.65% 23.82MiB 471.75KiB 9.63KiB 0 0.0193354 23.84MiB 331.66KiB 6.77KiB 0 0.0135839 False False
http_pipelines_blackhole_acks 164.67B 0.01 4.70% 1.23MiB 95.35KiB 1.94KiB 0 0.0755725 1.23MiB 94.19KiB 1.92KiB 0 0.0746405 False False
enterprise_http_to_http -1.29KiB -0.01 14.21% 23.85MiB 247.59KiB 5.05KiB 0 0.0101372 23.85MiB 250.46KiB 5.13KiB 0 0.0102553 False False
file_to_blackhole -36.87KiB -0.04 28.31% 95.34MiB 3.09MiB 63.97KiB 0 0.0323591 95.3MiB 3.8MiB 79.04KiB 0 0.0398597 False False
syslog_splunk_hec_logs -7.77KiB -0.05 29.14% 16.35MiB 748.73KiB 15.23KiB 0 0.0446978 16.35MiB 693.65KiB 14.13KiB 0 0.0414288 False False
splunk_hec_indexer_ack_blackhole -16.23KiB -0.07 51.10% 23.76MiB 780.78KiB 15.89KiB 0 0.0320796 23.75MiB 848.35KiB 17.25KiB 0 0.0348791 False False
splunk_hec_to_splunk_hec_logs_acks -30.56KiB -0.13 81.07% 23.78MiB 747.95KiB 15.23KiB 0 0.0307111 23.75MiB 865.62KiB 17.6KiB 0 0.0355872 False False
http_to_http_json -43.62KiB -0.18 99.90% 23.85MiB 346.95KiB 7.08KiB 0 0.0142057 23.8MiB 551.61KiB 11.25KiB 0 0.0226257 False False
syslog_loki -37.35KiB -0.24 96.73% 14.9MiB 418.41KiB 8.56KiB 0 0.0274167 14.86MiB 750.2KiB 15.25KiB 0 0.0492783 False False
splunk_hec_route_s3 -51.1KiB -0.27 55.47% 18.51MiB 2.3MiB 47.9KiB 0 0.124299 18.46MiB 2.24MiB 46.77KiB 0 0.121138 False False
http_to_http_acks -54.34KiB -0.31 18.58% 17.35MiB 7.68MiB 160.64KiB 0 0.442694 17.3MiB 7.96MiB 166.24KiB 0 0.460023 True True
http_to_http_noack -95.71KiB -0.39 99.99% 23.84MiB 405.13KiB 8.29KiB 0 0.0165937 23.74MiB 1.1MiB 23.01KiB 0 0.0464679 False False
syslog_log2metric_splunk_hec_metrics -76.45KiB -0.42 100.00% 17.9MiB 499.79KiB 10.19KiB 0 0.0272663 17.82MiB 737.96KiB 15.02KiB 0 0.0404285 False False
fluent_elasticsearch -364.12KiB -0.45 100.00% 79.47MiB 53.36KiB 1.08KiB 0 0.00065551 79.12MiB 4.22MiB 86.79KiB 0 0.0533506 False False
http_pipelines_blackhole -8.33KiB -0.48 99.94% 1.69MiB 23.58KiB 493.49B 0 0.0136336 1.68MiB 116.77KiB 2.38KiB 0 0.0678449 False False
datadog_agent_remap_datadog_logs_acks -351.96KiB -0.56 99.55% 61.71MiB 3.76MiB 78.57KiB 0 0.0609201 61.37MiB 4.59MiB 95.58KiB 0 0.0747908 False False
syslog_log2metric_humio_metrics -96.89KiB -0.73 100.00% 13.05MiB 129.97KiB 2.66KiB 0 0.00972378 12.96MiB 579.47KiB 11.79KiB 0 0.0436687 False False
datadog_agent_remap_datadog_logs -533.79KiB -0.85 100.00% 61.63MiB 2.02MiB 42.3KiB 0 0.032733 61.11MiB 4.46MiB 92.79KiB 0 0.0729022 False False
http_pipelines_no_grok_blackhole -142.87KiB -1.26 100.00% 11.08MiB 52.72KiB 1.08KiB 0 0.00464635 10.94MiB 1.1MiB 22.99KiB 0 0.100964 False False

@jszwedko
Copy link
Member

Same comment as #14117 (review)

Apologies for not catching this sooner!

@pablosichert pablosichert force-pushed the pablosichert/aws_ec2_metadata-transform-verify-compliance branch from 80cda00 to dc97e63 Compare September 2, 2022 20:49
@github-actions github-actions bot added domain: ci Anything related to Vector's CI environment domain: sources Anything related to the Vector's sources labels Sep 2, 2022
@pablosichert pablosichert changed the title enhancement(aws_ec2_metadata transform): Emit EventsReceived/EventsSent for aws_ec2_metadata transform chore(aws_ec2_metadata transform): Test compliance to instrumentation spec in aws_ec2_metadata transform Sep 2, 2022
@pablosichert
Copy link
Contributor Author

@jszwedko ha, no worries! That might have been a bit sloppy on my side as well 😄

@pablosichert pablosichert changed the base branch from master to pablosichert/dedupe-transform-verify-compliance September 2, 2022 20:52
@pablosichert pablosichert added the ci-condition: integration tests enable Run integration tests on this PR label Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Soak Test Results

Baseline: 7b877d6
Comparison: dc97e63
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
datadog_agent_remap_blackhole 1.81MiB 3.15 100.00% 57.48MiB 4.68MiB 97.51KiB 0 0.0814121 59.29MiB 3.3MiB 68.86KiB 0 0.0556375 False False
socket_to_socket_blackhole 626.65KiB 2.74 100.00% 22.31MiB 458.04KiB 9.35KiB 0 0.0200464 22.92MiB 624.26KiB 12.74KiB 0 0.0265914 False False
syslog_log2metric_humio_metrics 288.09KiB 2.31 100.00% 12.19MiB 422.95KiB 8.63KiB 0 0.0338863 12.47MiB 578.69KiB 11.79KiB 0 0.0453182 False False
datadog_agent_remap_blackhole_acks 1.12MiB 1.9 100.00% 58.88MiB 5.84MiB 121.66KiB 0 0.0991992 60.0MiB 4.7MiB 98.18KiB 0 0.0783659 False False
http_pipelines_blackhole_acks 22.03KiB 1.8 100.00% 1.19MiB 117.1KiB 2.38KiB 0 0.0956825 1.22MiB 72.14KiB 1.47KiB 0 0.0579046 False False
datadog_agent_remap_datadog_logs 1.0MiB 1.73 100.00% 58.04MiB 4.85MiB 101.59KiB 0 0.0835025 59.05MiB 5.92MiB 123.32KiB 0 0.100253 False False
http_text_to_http_json 505.47KiB 1.26 100.00% 39.31MiB 736.42KiB 15.03KiB 0 0.0182924 39.8MiB 706.53KiB 14.43KiB 0 0.0173321 False False
datadog_agent_remap_datadog_logs_acks 655.6KiB 1.06 100.00% 60.17MiB 3.87MiB 80.74KiB 0 0.0642628 60.81MiB 4.72MiB 98.31KiB 0 0.0776515 False False
syslog_log2metric_splunk_hec_metrics 128.84KiB 0.73 100.00% 17.26MiB 1.05MiB 21.98KiB 0 0.0610511 17.38MiB 1.07MiB 22.34KiB 0 0.0616342 False False
syslog_splunk_hec_logs 114.79KiB 0.7 100.00% 15.93MiB 879.05KiB 17.88KiB 0 0.0538609 16.05MiB 773.02KiB 15.76KiB 0 0.0470336 False False
syslog_loki 99.99KiB 0.67 100.00% 14.58MiB 612.6KiB 12.55KiB 0 0.0410226 14.68MiB 895.36KiB 18.2KiB 0 0.0595586 False False
http_pipelines_blackhole 10.59KiB 0.61 99.99% 1.7MiB 60.27KiB 1.23KiB 0 0.0346767 1.71MiB 122.55KiB 2.5KiB 0 0.0700854 False False
syslog_regex_logs2metric_ddmetrics 56.22KiB 0.44 99.86% 12.42MiB 616.54KiB 12.55KiB 0 0.0484688 12.47MiB 601.68KiB 12.25KiB 0 0.0470923 False False
syslog_humio_logs 57.04KiB 0.34 100.00% 16.41MiB 141.02KiB 2.88KiB 0 0.00839156 16.46MiB 160.88KiB 3.29KiB 0 0.00954076 False False
splunk_hec_route_s3 24.25KiB 0.13 27.36% 18.19MiB 2.38MiB 49.49KiB 0 0.130648 18.22MiB 2.32MiB 48.48KiB 0 0.127207 False False
splunk_hec_to_splunk_hec_logs_noack 22.19KiB 0.09 92.52% 23.82MiB 508.16KiB 10.37KiB 0 0.0208309 23.84MiB 337.58KiB 6.89KiB 0 0.013826 False False
splunk_hec_to_splunk_hec_logs_acks 14.87KiB 0.06 46.84% 23.75MiB 855.94KiB 17.41KiB 0 0.0351872 23.76MiB 795.8KiB 16.19KiB 0 0.0326948 False False
splunk_hec_indexer_ack_blackhole 2.59KiB 0.01 8.47% 23.75MiB 853.33KiB 17.36KiB 0 0.0350757 23.76MiB 839.44KiB 17.08KiB 0 0.0345013 False False
enterprise_http_to_http -911.31B -0 9.57% 23.85MiB 258.29KiB 5.27KiB 0 0.0105759 23.84MiB 254.33KiB 5.2KiB 0 0.010414 False False
http_pipelines_no_grok_blackhole -6.99KiB -0.06 24.77% 10.99MiB 63.25KiB 1.29KiB 0 0.00562178 10.98MiB 1.06MiB 22.11KiB 0 0.0966726 False False
file_to_blackhole -63.46KiB -0.07 40.65% 95.31MiB 3.94MiB 81.56KiB 0 0.041323 95.24MiB 4.16MiB 86.48KiB 0 0.0436928 False False
fluent_elasticsearch -121.08KiB -0.15 100.00% 79.47MiB 54.17KiB 1.1KiB 0 0.000665496 79.36MiB 1.26MiB 25.89KiB 0 0.0158341 False False
http_to_http_json -53.53KiB -0.22 99.99% 23.85MiB 330.23KiB 6.74KiB 0 0.0135207 23.79MiB 607.09KiB 12.38KiB 0 0.0249105 False False
http_to_http_noack -73.97KiB -0.3 99.97% 23.84MiB 259.7KiB 5.31KiB 0 0.0106342 23.77MiB 962.44KiB 19.61KiB 0 0.0395295 False False
http_to_http_acks -230.09KiB -1.29 68.97% 17.48MiB 7.66MiB 160.07KiB 0 0.437903 17.26MiB 7.7MiB 160.63KiB 0 0.445991 True True

Base automatically changed from pablosichert/dedupe-transform-verify-compliance to pablosichert/dedupe-transform-verify-compliance-dropped September 7, 2022 18:17
Base automatically changed from pablosichert/dedupe-transform-verify-compliance-dropped to master September 12, 2022 15:29
@pablosichert pablosichert force-pushed the pablosichert/aws_ec2_metadata-transform-verify-compliance branch from dc97e63 to 22bb7ef Compare September 13, 2022 12:57
@github-actions github-actions bot removed domain: ci Anything related to Vector's CI environment domain: sources Anything related to the Vector's sources labels Sep 13, 2022
@github-actions
Copy link

Soak Test Results

Baseline: 2189555
Comparison: 22bb7ef
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
datadog_agent_remap_blackhole 2.11MiB 4.06 100.00% 52.01MiB 6.23MiB 129.83KiB 0 0.119747 54.12MiB 6.32MiB 131.75KiB 0 0.116684 False False
socket_to_socket_blackhole 299.2KiB 1.26 100.00% 23.1MiB 747.02KiB 15.25KiB 0 0.0315679 23.4MiB 190.04KiB 3.88KiB 0 0.0079307 False False
syslog_log2metric_humio_metrics 97.75KiB 0.81 99.45% 11.72MiB 1.2MiB 25.1KiB 0 0.102354 11.82MiB 1.18MiB 24.63KiB 0 0.099913 False False
http_to_http_acks 89.11KiB 0.5 29.06% 17.31MiB 8.17MiB 170.95KiB 0 0.472234 17.39MiB 8.02MiB 167.21KiB 0 0.460852 True True
splunk_hec_route_s3 88.02KiB 0.46 82.41% 18.81MiB 2.24MiB 46.6KiB 0 0.118995 18.89MiB 2.17MiB 45.34KiB 0 0.114708 False False
http_pipelines_blackhole 5.35KiB 0.31 98.90% 1.69MiB 41.35KiB 865.12B 0 0.0238531 1.7MiB 94.45KiB 1.93KiB 0 0.0543196 False False
http_text_to_http_json 122.65KiB 0.31 100.00% 38.22MiB 830.01KiB 16.94KiB 0 0.0212039 38.34MiB 823.56KiB 16.82KiB 0 0.0209736 False False
datadog_agent_remap_datadog_logs 179.02KiB 0.28 91.92% 61.67MiB 2.21MiB 46.3KiB 0 0.0358098 61.85MiB 4.39MiB 91.46KiB 0 0.0709981 False False
http_pipelines_blackhole_acks 2.68KiB 0.22 63.70% 1.21MiB 120.13KiB 2.44KiB 0 0.0968814 1.21MiB 80.42KiB 1.64KiB 0 0.0647211 False False
splunk_hec_to_splunk_hec_logs_noack 29.58KiB 0.12 97.30% 23.81MiB 562.8KiB 11.48KiB 0 0.0230811 23.84MiB 335.75KiB 6.85KiB 0 0.0137526 False False
syslog_humio_logs 18.17KiB 0.11 99.85% 16.07MiB 177.22KiB 3.62KiB 0 0.0107685 16.09MiB 215.51KiB 4.41KiB 0 0.0130802 False False
datadog_agent_remap_blackhole_acks 26.47KiB 0.04 19.09% 58.95MiB 4.26MiB 88.81KiB 0 0.072294 58.98MiB 3.07MiB 64.15KiB 0 0.0519831 False False
syslog_splunk_hec_logs 4.07KiB 0.02 15.65% 16.34MiB 742.62KiB 15.11KiB 0 0.0443818 16.34MiB 688.6KiB 14.03KiB 0 0.0411434 False False
splunk_hec_indexer_ack_blackhole -1.1KiB -0 3.34% 23.75MiB 906.92KiB 18.45KiB 0 0.0372798 23.75MiB 916.7KiB 18.65KiB 0 0.0376836 False False
enterprise_http_to_http -3.4KiB -0.01 35.96% 23.85MiB 254.11KiB 5.19KiB 0 0.0104034 23.84MiB 249.77KiB 5.12KiB 0 0.0102273 False False
file_to_blackhole -48.24KiB -0.05 34.46% 95.34MiB 3.54MiB 73.46KiB 0 0.0371643 95.29MiB 3.81MiB 79.27KiB 0 0.0399817 False False
splunk_hec_to_splunk_hec_logs_acks -22.12KiB -0.09 63.91% 23.77MiB 798.33KiB 16.25KiB 0 0.0327974 23.74MiB 882.45KiB 17.95KiB 0 0.0362862 False False
syslog_log2metric_splunk_hec_metrics -19.99KiB -0.11 73.95% 17.47MiB 564.9KiB 11.51KiB 0 0.0315713 17.45MiB 663.63KiB 13.52KiB 0 0.0371308 False False
datadog_agent_remap_datadog_logs_acks -76.68KiB -0.12 48.65% 61.45MiB 3.44MiB 71.9KiB 0 0.0559859 61.38MiB 4.46MiB 92.74KiB 0 0.0725728 False False
syslog_loki -23.93KiB -0.16 85.40% 14.58MiB 347.82KiB 7.12KiB 0 0.0232879 14.56MiB 729.92KiB 14.84KiB 0 0.0489501 False False
http_to_http_json -47.56KiB -0.19 99.95% 23.85MiB 338.08KiB 6.9KiB 0 0.013841 23.8MiB 579.27KiB 11.82KiB 0 0.0237617 False False
fluent_elasticsearch -282.43KiB -0.35 100.00% 79.47MiB 51.86KiB 1.05KiB 0 0.000637134 79.2MiB 3.27MiB 67.21KiB 0 0.0412286 False False
syslog_regex_logs2metric_ddmetrics -59.21KiB -0.47 99.99% 12.31MiB 546.01KiB 11.12KiB 0 0.0433036 12.25MiB 483.09KiB 9.85KiB 0 0.0384939 False False
http_to_http_noack -122.52KiB -0.5 100.00% 23.85MiB 251.07KiB 5.13KiB 0 0.0102802 23.73MiB 1.19MiB 24.86KiB 0 0.0502731 False False
http_pipelines_no_grok_blackhole -132.17KiB -1.2 100.00% 10.73MiB 108.9KiB 2.22KiB 0 0.00991122 10.6MiB 1.06MiB 22.02KiB 0 0.0997819 False False

@pablosichert pablosichert merged commit cc9155f into master Sep 14, 2022
@pablosichert pablosichert deleted the pablosichert/aws_ec2_metadata-transform-verify-compliance branch September 14, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-condition: integration tests enable Run integration tests on this PR domain: transforms Anything related to Vector's transform components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants